Commit Graph

71 Commits

Author SHA1 Message Date
cf67fe6476 nit pick 2021-02-04 15:22:23 +05:30
9edecbfc86 Bootstrap Packer template for libvirt and Vbox
Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
2021-02-04 10:27:19 +01:00
3d387cd26e Use same IP address for both boots and nginx (#43)
Signed-off-by: Michael Richard <michael.richard.ing@gmail.com>

## Description

This configures NGINX to listen on port 8080 and lets go the need to configure a second IP address on the host dedicated to NGINX.

## Why is this needed

Setting up a second IP address to host NGINX on the same host is not always easy, especially when running tinkerbell on network devices like switches. The second IP address adds a useless level of complexity. In the future, all the code required to identify the host operating system and configure the IP address could even be removed and left as a prerequisite, since the host is likely to have an IP address already configured.

## How Has This Been Tested?

The untouched vagrant_test.go test ran sucessfully.

## How are existing users impacted? What migration steps/scripts do we need?

Simply re-applying the docker-compose.yml should be sufficient (untested).
Additional firewall rules to allow traffic on port 8080 could be required depending on user's network configuration.

## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
2021-01-27 10:39:13 +00:00
141083e24d Merge branch 'master' into single-ip-address 2021-01-27 10:38:39 +00:00
c67898ed52 Fix vagrant config for libvirt (#42)
## Description

Fixes the vagrant configuration when using libvirt

## Why is this needed

Without this issue the vagrant provisioner fails when using libvirt with the following error:

```sh
Error occurred while creating new network: {:iface_type=>:private_network, :netmask=>"255.255.255.0", :dhcp_enabled=>false, :forward_mode=>"none", :virtualbox__intnet=>"tink_network", :libvirt__dhcp_enabled=>false, :libvirt__forward_mode=>"none", :auto_config=>false, :protocol=>"tcp", :id=>"18e6fc6d-41b8-40c9-814d-ffc476bfd920"}.
```

## How Has This Been Tested?

Reran vagrant up after making the changes and the provisioner machine successfully was created


## How are existing users impacted? What migration steps/scripts do we need?

Should not affect existing users unless they were trying to use vagrant/libvirt and were unsuccessful before.

No migration should be needed.
2021-01-26 10:17:25 +00:00
c7b84264af Set NGINX to bind on TINKERBELL_HOST_IP:8080
Signed-off-by: Michael Richard <michael.richard.ing@gmail.com>
2021-01-25 15:19:23 -05:00
6150dd91c7 Fix vagrant config for libvirt 2021-01-25 15:00:02 -05:00
cc39216b67 Merge pull request #44 from gianarb/hotfix/shfmt-tinkerbell-sh
Fix shfmt for tinkerbell.sh file
2021-01-25 19:18:25 +01:00
e4d8fafa33 Fix shfmt for tinkerbell.sh file
Not sure how I happened but it looks like we introduced an shfmt error
in master

Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
2021-01-25 19:06:31 +01:00
89a304f4a7 Fix NAT and make it working for Terraform and Vagrant (#41)
Commit b504810 introduced a NAT to make worker capable of reaching the
public internet via the provisioner.

But it also introduced a bug, it only works for the Vagrant setup as
Manny pointed out:

https://github.com/tinkerbell/sandbox/pull/33#issuecomment-759651035

This is an attempt to fix it

@mmlb I would like to avoid additional conditions as part of the
setup.sh, we have already too many of them and they are not even easy to
dsicover. We have different entrypoint for those environment let's use them.
2021-01-23 03:44:11 +00:00
243777b6ef Fix NAT and make it working for Terraform and Vagrant
Commit b504810 introduced a NAT to make worker capable of reaching the
public internet via the provisioner.

But it also introduced a bug, it only works for the Vagrant setup as
Manny pointed out:

https://github.com/tinkerbell/sandbox/pull/33#issuecomment-759651035

This is an attempt to fix it

Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
2021-01-22 16:40:08 +01:00
f07e3d8d72 Update boots (#39)
## Description

Update boots version.

## Why is this needed

This will get us proper binaries in the releases but also 64bit boots
for 64bit x86 machines!

## How Has This Been Tested?

Boots has been tested on EM hw.
v0.4.0
2021-01-20 15:44:33 +00:00
ee945b31c9 Update boots
This will get us proper binaries in the releases but also 64bit boots
for 64bit x86 machines!

Signed-off-by: Manuel Mendez <mmendez@equinix.com>
2021-01-20 10:20:49 -05:00
ce7a79b75d getbinariesfromquay: Remove - separating arch from variant (#38)
## Description

Renames binaries to be more consistent in and of itself and also compared to other Go projects that provide multi-arch binaries.

## Why is this needed

@gianarb asked me to rename the binaries in https://github.com/tinkerbell/boots/pull/122 to match this scheme, but I think that this PR is the better directon.
2021-01-20 15:02:16 +00:00
e8ffd43a29 getbinariesfromquay: Remove - separating arch from variant
This naming scheme seemed weird to me so I went looking around at other
Go projects. None of the projects that I found that had multi-arch
release binaries used this scheme, instead they just append the variant
to arch. Appending the variant to the arch also makes a lot of sense if
you think of the naming schme as $binary-$os-$cpu and
$cpu=$arch$variant. Keeping arch and variant together as $cpu is also
more consistent, and consitency is great :D.

Signed-off-by: Manuel Mendez <mmendez@equinix.com>
2021-01-20 09:37:59 -05:00
b385de2b5a Merge pull request #36 from gauravgahlot/version-constraints
Add missing version constraints for providers - null, template
2021-01-12 09:23:49 +01:00
9dc63fbdb6 happy terraform fmt
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
2021-01-12 12:28:06 +05:30
60270f3164 add missing version constraints for providers - null, template
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
2021-01-12 12:10:17 +05:30
68c334307c Merge pull request #34 from gianarb/bump/20210111
Bump tink stack 2021 01 11
v0.3.0
2021-01-11 17:50:19 +05:30
be40a7b371 Bump tink stack 2021 01 11
Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
2021-01-11 12:24:26 +01:00
b504810679 provisioner setup changes to enable NAT for workers (#33)
## Description

Provisioner NAT setup for workers 

## Why is this needed

internet access on workers 
https://github.com/tinkerbell/sandbox/issues/31 


Fixes: #

## How Has This Been Tested?

- workflow executed successfully.
- ping from workers works correctly.

PR in reference with https://github.com/tinkerbell/tink/pull/410
2021-01-07 13:43:24 +00:00
7acaae68b4 provisioner setup changes to enable NAT for workers
provisioner setup changes to enable NAT for workers

Signed-off-by: cbkhare <Chitrabasukhare89@gmail.com>
2021-01-07 14:49:10 +05:30
0cb5e79447 Making statement on breaking changes clearer (#32)
## Description

Documentation

## Why is this needed

This statement is confusing, I needed to log into the community slack to get clarification.

Fixes: #

## How Has This Been Tested?
This is a documentation change and thus will not impact any software in this project.

## How are existing users impacted? What migration steps/scripts do we need?
They are not, newer users may find this a little easier to digest.


## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
2021-01-04 23:06:31 +00:00
64cc641150 Making statement on breaking changes clearer
Signed-off-by: jgavinray <jgavinray@linux.com>
2021-01-04 12:07:15 -08:00
3a5445e583 Merge pull request #29 from qmfrederik/fixes/windows-onboarding
For Unix-style line endings for scripts, add .env to .gitignore
2020-12-10 15:10:45 +01:00
2499b89fe6 Merge pull request #30 from tinkerbell/fix/cleanup-not-required-sql-init
Cleanup not required cleanup sql script
2020-12-10 15:08:51 +01:00
22f6f22012 Cleanup not required cleanup sql script
Since we introduced migration the init file is not required and it is a
leftover.

Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
2020-12-10 14:42:24 +01:00
5b7ce84149 Add .env to .gitignore
Signed-off-by: Frederik Carlier <frederik.carlier@quamotion.mobi>
2020-12-07 23:31:00 +01:00
92ea28a0ad Force Unix line endings for shell scripts
Signed-off-by: Frederik Carlier <frederik.carlier@quamotion.mobi>
2020-12-07 23:31:00 +01:00
d04bee185a Merge pull request #28 from gianarb/fix/update-aptrepos-tag-workflow
Run apt-update before installing package in the tag workflow
v0.2.1
2020-11-24 20:08:31 +01:00
ee992dd8d4 Run apt-update before installing package in the tag workflow
Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
2020-11-24 19:52:15 +01:00
1b408b0f4f Missed docker transport in release-binaries (#26)
Regression from f8cf83f121
2020-11-24 18:30:04 +00:00
c2c41101cb Merge branch 'master' into getbinaries-fix-transport 2020-11-24 18:28:04 +00:00
2db68f09b6 Unpack all image and not just the last layer (#27)
The go program we use to get binaries from a docker image was unpacking
only the last layer. This is not required and in order to have a more
generic approach and fewest requirement the program now unpack all the
image
2020-11-24 16:29:08 +00:00
84f4fa8533 Merge branch 'master' into unpack-all-image 2020-11-24 16:28:31 +00:00
f6b43ada0b Unpack all image and not just the last layer
The go program we use to get binaries from a docker image was unpacking
only the last layer. This is not required and it order to have a more
generic approach and fewest requirement the program now unpack all the
image

Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
2020-11-24 17:12:33 +01:00
2650e324df Missed docker transport in release-binaries
This is a regression introduced here f8cf83f121

Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
2020-11-24 17:08:08 +01:00
e08401172c bump boots to 45a64dad03795133adf7f7177677f3d58a0018e2 (#25)
bump boots to 45a64dad03795133adf7f7177677f3d58a0018e2
2020-11-24 15:44:45 +00:00
87fca37075 bump boots to 45a64dad03795133adf7f7177677f3d58a0018e2
The main reason for this bump is because we fixed multi arch support for
boots binaries. Before docker images were multi arch but boots was
always x86. This issue is not fixed.

Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
2020-11-24 16:41:58 +01:00
1672752d56 Merge pull request #24 from tinkerbell/hotfix/use-current-versions
Use variables set in current_versions.sh as part of script/release-binaries.sh
2020-11-23 20:00:02 +05:30
f8cf83f121 Use variables set in current_versions.sh as part of
script/release-binaries.sh

When writing the release-binary bash script I didn't use the right
variables in current_versions.sh but I fixed those values as part of the
script itself.

Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
2020-11-23 15:22:59 +01:00
587e65181a Merge pull request #23 from tinkerbell/release-binaries
Push binaries as release artifact
v0.2.0
2020-11-19 11:47:34 +01:00
509524bd14 Add continuous integration workflow
Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
2020-11-19 11:30:32 +01:00
45f593449a CLI to get binaries from a docker image with multi arch support
have a look at the README.md to see how it works.

Bootstrap a CLI program to copy binaries from multi arch images

Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
2020-11-16 17:50:40 +01:00
4790ba4871 Bump tinkerbell stack to newest versions (#22)
Bump tinkerbell stack to newest versions
2020-11-16 16:19:23 +00:00
fdaab9b279 bump tink for e2e test
Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
2020-11-12 17:29:05 +01:00
1c4f829252 Bump tinkerbell stack to newest versions
Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
2020-11-12 17:12:42 +01:00
09adeb815f Merge pull request #21 from tinkerbell/lint-and-format-checks-in-ci
Lint and format checks in ci
2020-11-10 09:25:34 +01:00
f133299bec Add ci-non-go.sh checks as part of CI
Signed-off-by: Manuel Mendez <mmendez@equinix.com>
2020-11-09 17:39:00 -05:00
731f9563fd Ensure all files pass ci-non-go.sh checks.
Signed-off-by: Manuel Mendez <mmendez@equinix.com>
2020-11-09 17:39:00 -05:00