getbinariesfromquay: Remove - separating arch from variant
This naming scheme seemed weird to me so I went looking around at other Go projects. None of the projects that I found that had multi-arch release binaries used this scheme, instead they just append the variant to arch. Appending the variant to the arch also makes a lot of sense if you think of the naming schme as $binary-$os-$cpu and $cpu=$arch$variant. Keeping arch and variant together as $cpu is also more consistent, and consitency is great :D. Signed-off-by: Manuel Mendez <mmendez@equinix.com>
This commit is contained in:
parent
b385de2b5a
commit
e8ffd43a29
@ -88,7 +88,7 @@ func main() {
|
||||
}
|
||||
if arch.Platform.Variant != "" {
|
||||
syss.VariantChoice = arch.Platform.Variant
|
||||
imgDir = imgDir + "-" + arch.Platform.Variant
|
||||
imgDir = imgDir + arch.Platform.Variant
|
||||
}
|
||||
archImg, err := docker.ImageFromName(ctx, syss, imageR)
|
||||
if err != nil {
|
||||
|
Loading…
Reference in New Issue
Block a user