djpbessems/Tinkerbell.Sandbox
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

getbinariesfromquay: Remove - separating arch from variant

Browse Source 
This naming scheme seemed weird to me so I went looking around at other
Go projects. None of the projects that I found that had multi-arch
release binaries used this scheme, instead they just append the variant
to arch. Appending the variant to the arch also makes a lot of sense if
you think of the naming schme as $binary-$os-$cpu and
$cpu=$arch$variant. Keeping arch and variant together as $cpu is also
more consistent, and consitency is great :D.

Signed-off-by: Manuel Mendez <mmendez@equinix.com>
This commit is contained in:
Manuel Mendez
2021-01-20 09:33:14 -05:00
parent b385de2b5a
commit e8ffd43a29
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/getbinariesfromquay/main.go
View File

@@ -88,7 +88,7 @@ func main() {
} }
if arch.Platform.Variant != "" { if arch.Platform.Variant != "" {
syss.VariantChoice = arch.Platform.Variant syss.VariantChoice = arch.Platform.Variant
imgDir = imgDir + "-" + arch.Platform.Variant imgDir = imgDir + arch.Platform.Variant
} }
archImg, err := docker.ImageFromName(ctx, syss, imageR) archImg, err := docker.ImageFromName(ctx, syss, imageR)
if err != nil { if err != nil {