djpbessems/ContainerImage.Pinniped
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wip011

Browse Source 
Signed-off-by: Monis Khan <mok@vmware.com>
This commit is contained in:
Monis Khan 2022-07-21 00:17:11 -04:00
parent cbcb527ce3
commit f126ef4eaf
No known key found for this signature in database
GPG Key ID: 52C90ADA01B269B8
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
internal/registry/clientsecretrequest/rest.go
View File

@ -199,11 +199,11 @@ func (r *REST) validateRequest(
return nil, apierrors.NewBadRequest(fmt.Sprintf("not an OIDCClientSecretRequest: %#v", obj)) return nil, apierrors.NewBadRequest(fmt.Sprintf("not an OIDCClientSecretRequest: %#v", obj))
} }
// TODO validate these fields // TODO validate these fields, copy BeforeCreate logic
_ = clientSecretRequest.Name _ = clientSecretRequest.Name // -> non-empty, has prefix
_ = clientSecretRequest.GenerateName _ = clientSecretRequest.GenerateName // --> empty
_ = clientSecretRequest.Namespace _ = clientSecretRequest.Namespace // matches
_ = clientSecretRequest.ResourceVersion _ = clientSecretRequest.ResourceVersion // empty?
// just a sanity check, not sure how to honor a dry run on a virtual API // just a sanity check, not sure how to honor a dry run on a virtual API
if options != nil { if options != nil {