From f126ef4eaf877e7def1ad5b6a10ace6d760fde80 Mon Sep 17 00:00:00 2001 From: Monis Khan Date: Thu, 21 Jul 2022 00:17:11 -0400 Subject: [PATCH] wip011 Signed-off-by: Monis Khan --- internal/registry/clientsecretrequest/rest.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/internal/registry/clientsecretrequest/rest.go b/internal/registry/clientsecretrequest/rest.go index 4fb44b42..a6414433 100644 --- a/internal/registry/clientsecretrequest/rest.go +++ b/internal/registry/clientsecretrequest/rest.go @@ -199,11 +199,11 @@ func (r *REST) validateRequest( return nil, apierrors.NewBadRequest(fmt.Sprintf("not an OIDCClientSecretRequest: %#v", obj)) } - // TODO validate these fields - _ = clientSecretRequest.Name - _ = clientSecretRequest.GenerateName - _ = clientSecretRequest.Namespace - _ = clientSecretRequest.ResourceVersion + // TODO validate these fields, copy BeforeCreate logic + _ = clientSecretRequest.Name // -> non-empty, has prefix + _ = clientSecretRequest.GenerateName // --> empty + _ = clientSecretRequest.Namespace // matches + _ = clientSecretRequest.ResourceVersion // empty? // just a sanity check, not sure how to honor a dry run on a virtual API if options != nil {