djpbessems/ContainerImage.Pinniped
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Get rid of TODOs in code by punting on them

Browse Source 
We will do these later; they have been recorded in a work tracking record.

Signed-off-by: Andrew Keesler <akeesler@vmware.com>
This commit is contained in:
Andrew Keesler 2020-12-15 09:58:23 -05:00
parent d2498c96e0
commit 7320928235
No known key found for this signature in database
GPG Key ID: 27CE0444346F9413
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
internal/controller/supervisorconfig/generator/oidc_provider_secrets.go
View File

@ -56,7 +56,6 @@ func NewOIDCProviderSecretsController(
}, },
// We want to be notified when a OPC's secret gets updated or deleted. When this happens, we // We want to be notified when a OPC's secret gets updated or deleted. When this happens, we
// should get notified via the corresponding OPC key. // should get notified via the corresponding OPC key.
// TODO: de-dup me (jwks_writer.go).
withInformer( withInformer(
secretInformer, secretInformer,
pinnipedcontroller.SimpleFilter(isOPControllee, func(obj metav1.Object) controllerlib.Key { pinnipedcontroller.SimpleFilter(isOPControllee, func(obj metav1.Object) controllerlib.Key {

1
internal/controller/supervisorconfig/generator/supervisor_secrets.go
View File

@ -36,7 +36,6 @@ type supervisorSecretsController struct {
// NewSupervisorSecretsController instantiates a new controllerlib.Controller which will ensure existence of a generated secret. // NewSupervisorSecretsController instantiates a new controllerlib.Controller which will ensure existence of a generated secret.
func NewSupervisorSecretsController( func NewSupervisorSecretsController(
// TODO: generate the name for the secret and label the secret with the UID of the owner? So that we don't have naming conflicts if the user has already created a Secret with that name.
owner *appsv1.Deployment, owner *appsv1.Deployment,
labels map[string]string, labels map[string]string,
kubeClient kubernetes.Interface, kubeClient kubernetes.Interface,