From 73209282355bce9c5edd41b34e745a29ed5b7f26 Mon Sep 17 00:00:00 2001 From: Andrew Keesler Date: Tue, 15 Dec 2020 09:58:23 -0500 Subject: [PATCH] Get rid of TODOs in code by punting on them We will do these later; they have been recorded in a work tracking record. Signed-off-by: Andrew Keesler --- .../supervisorconfig/generator/oidc_provider_secrets.go | 1 - .../controller/supervisorconfig/generator/supervisor_secrets.go | 1 - 2 files changed, 2 deletions(-) diff --git a/internal/controller/supervisorconfig/generator/oidc_provider_secrets.go b/internal/controller/supervisorconfig/generator/oidc_provider_secrets.go index aeada106..b188cc18 100644 --- a/internal/controller/supervisorconfig/generator/oidc_provider_secrets.go +++ b/internal/controller/supervisorconfig/generator/oidc_provider_secrets.go @@ -56,7 +56,6 @@ func NewOIDCProviderSecretsController( }, // We want to be notified when a OPC's secret gets updated or deleted. When this happens, we // should get notified via the corresponding OPC key. - // TODO: de-dup me (jwks_writer.go). withInformer( secretInformer, pinnipedcontroller.SimpleFilter(isOPControllee, func(obj metav1.Object) controllerlib.Key { diff --git a/internal/controller/supervisorconfig/generator/supervisor_secrets.go b/internal/controller/supervisorconfig/generator/supervisor_secrets.go index d3155520..cc5153a5 100644 --- a/internal/controller/supervisorconfig/generator/supervisor_secrets.go +++ b/internal/controller/supervisorconfig/generator/supervisor_secrets.go @@ -36,7 +36,6 @@ type supervisorSecretsController struct { // NewSupervisorSecretsController instantiates a new controllerlib.Controller which will ensure existence of a generated secret. func NewSupervisorSecretsController( - // TODO: generate the name for the secret and label the secret with the UID of the owner? So that we don't have naming conflicts if the user has already created a Secret with that name. owner *appsv1.Deployment, labels map[string]string, kubeClient kubernetes.Interface,