Get rid of TODOs in code by punting on them
We will do these later; they have been recorded in a work tracking record. Signed-off-by: Andrew Keesler <akeesler@vmware.com>
This commit is contained in:
parent
d2498c96e0
commit
7320928235
@ -56,7 +56,6 @@ func NewOIDCProviderSecretsController(
|
||||
},
|
||||
// We want to be notified when a OPC's secret gets updated or deleted. When this happens, we
|
||||
// should get notified via the corresponding OPC key.
|
||||
// TODO: de-dup me (jwks_writer.go).
|
||||
withInformer(
|
||||
secretInformer,
|
||||
pinnipedcontroller.SimpleFilter(isOPControllee, func(obj metav1.Object) controllerlib.Key {
|
||||
|
@ -36,7 +36,6 @@ type supervisorSecretsController struct {
|
||||
|
||||
// NewSupervisorSecretsController instantiates a new controllerlib.Controller which will ensure existence of a generated secret.
|
||||
func NewSupervisorSecretsController(
|
||||
// TODO: generate the name for the secret and label the secret with the UID of the owner? So that we don't have naming conflicts if the user has already created a Secret with that name.
|
||||
owner *appsv1.Deployment,
|
||||
labels map[string]string,
|
||||
kubeClient kubernetes.Interface,
|
||||
|
Loading…
Reference in New Issue
Block a user