djpbessems/ContainerImage.Pinniped
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove a couple of todos that will be resolved in Slack conversations

Browse Source
This commit is contained in:
Ryan Richard 2020-12-02 14:20:03 -08:00
parent c320132289
commit 6ed9107df0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/crud/crud.go
View File

@ -30,7 +30,7 @@ const (
ErrSecretTypeMismatch = constable.Error("secret storage data has incorrect type") ErrSecretTypeMismatch = constable.Error("secret storage data has incorrect type")
ErrSecretLabelMismatch = constable.Error("secret storage data has incorrect label") ErrSecretLabelMismatch = constable.Error("secret storage data has incorrect label")
ErrSecretVersionMismatch = constable.Error("secret storage data has incorrect version") // TODO do we need this? ErrSecretVersionMismatch = constable.Error("secret storage data has incorrect version")
) )
type Storage interface { type Storage interface {
@ -139,7 +139,7 @@ func (s *secretsStorage) toSecret(signature, resourceVersion string, data JSON)
Labels: map[string]string{ Labels: map[string]string{
secretLabelKey: s.resource, // make it easier to find this stuff via kubectl secretLabelKey: s.resource, // make it easier to find this stuff via kubectl
}, },
OwnerReferences: nil, // TODO we should set this to make sure stuff gets clean up OwnerReferences: nil,
}, },
Data: map[string][]byte{ Data: map[string][]byte{
secretDataKey: buf, secretDataKey: buf,