From 6ed9107df02ca409b7bc61631b247d9050b3ed23 Mon Sep 17 00:00:00 2001 From: Ryan Richard Date: Wed, 2 Dec 2020 14:20:03 -0800 Subject: [PATCH] Remove a couple of todos that will be resolved in Slack conversations --- internal/crud/crud.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/crud/crud.go b/internal/crud/crud.go index 82d32082..9e15581d 100644 --- a/internal/crud/crud.go +++ b/internal/crud/crud.go @@ -30,7 +30,7 @@ const ( ErrSecretTypeMismatch = constable.Error("secret storage data has incorrect type") ErrSecretLabelMismatch = constable.Error("secret storage data has incorrect label") - ErrSecretVersionMismatch = constable.Error("secret storage data has incorrect version") // TODO do we need this? + ErrSecretVersionMismatch = constable.Error("secret storage data has incorrect version") ) type Storage interface { @@ -139,7 +139,7 @@ func (s *secretsStorage) toSecret(signature, resourceVersion string, data JSON) Labels: map[string]string{ secretLabelKey: s.resource, // make it easier to find this stuff via kubectl }, - OwnerReferences: nil, // TODO we should set this to make sure stuff gets clean up + OwnerReferences: nil, }, Data: map[string][]byte{ secretDataKey: buf,