djpbessems/ContainerImage.Pinniped
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removed a todo that was resolved

Browse Source
This commit is contained in:
Margo Crawford 2021-07-23 08:47:56 -07:00
parent 1050f39789
commit 5d23068690
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/controller/supervisorconfig/activedirectoryupstreamwatcher/active_directory_upstream_watcher_test.go
View File

@ -296,11 +296,6 @@ func TestActiveDirectoryUpstreamWatcherControllerSync(t *testing.T) {
activeDirectoryConnectionValidTrueCondition(gen, secretVersion), activeDirectoryConnectionValidTrueCondition(gen, secretVersion),
searchBaseFoundInConfigCondition(gen), searchBaseFoundInConfigCondition(gen),
tlsConfigurationValidLoadedTrueCondition(gen), tlsConfigurationValidLoadedTrueCondition(gen),
// TODO should there be a condition when you just get it from the config? is that worth reporting?
// I'm thinking maybe no since it's not a network call or anything... it's just like any other field in the
// spec that we don't bother to report on.
// Although perhaps it would be weirder to have a condition that only sometimes exists? And it's a useful
// way to communicate internally.
} }
} }