From 5d23068690571bf08eff400232d328f1842a7330 Mon Sep 17 00:00:00 2001 From: Margo Crawford Date: Fri, 23 Jul 2021 08:47:56 -0700 Subject: [PATCH] Removed a todo that was resolved --- .../active_directory_upstream_watcher_test.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/internal/controller/supervisorconfig/activedirectoryupstreamwatcher/active_directory_upstream_watcher_test.go b/internal/controller/supervisorconfig/activedirectoryupstreamwatcher/active_directory_upstream_watcher_test.go index 6d11d0cb..6fbd2d73 100644 --- a/internal/controller/supervisorconfig/activedirectoryupstreamwatcher/active_directory_upstream_watcher_test.go +++ b/internal/controller/supervisorconfig/activedirectoryupstreamwatcher/active_directory_upstream_watcher_test.go @@ -296,11 +296,6 @@ func TestActiveDirectoryUpstreamWatcherControllerSync(t *testing.T) { activeDirectoryConnectionValidTrueCondition(gen, secretVersion), searchBaseFoundInConfigCondition(gen), tlsConfigurationValidLoadedTrueCondition(gen), - // TODO should there be a condition when you just get it from the config? is that worth reporting? - // I'm thinking maybe no since it's not a network call or anything... it's just like any other field in the - // spec that we don't bother to report on. - // Although perhaps it would be weirder to have a condition that only sometimes exists? And it's a useful - // way to communicate internally. } }