djpbessems/ContainerImage.Pinniped
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "test/integration: skip TestSupervisorLogin until new callback logic is on main"

Browse Source 
This reverts commit eae6d355f8.

We have added the new callback path logic (see b21f003), so we can stop skipping
this test.
This commit is contained in:
Andrew Keesler 2020-11-30 11:07:25 -05:00
parent 25bbd28527
commit 58a3e35c51
No known key found for this signature in database
GPG Key ID: 27CE0444346F9413
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/integration/supervisor_login_test.go
View File

@ -28,8 +28,6 @@ import (
) )
func TestSupervisorLogin(t *testing.T) { func TestSupervisorLogin(t *testing.T) {
t.Skip("waiting on new callback path logic to get merged in from the callback endpoint work")
env := library.IntegrationEnv(t) env := library.IntegrationEnv(t)
client := library.NewSupervisorClientset(t) client := library.NewSupervisorClientset(t)
@ -117,7 +115,6 @@ func TestSupervisorLogin(t *testing.T) {
} }
} }
//nolint:unused
func getDownstreamIssuerPathFromUpstreamRedirectURI(t *testing.T, upstreamRedirectURI string) string { func getDownstreamIssuerPathFromUpstreamRedirectURI(t *testing.T, upstreamRedirectURI string) string {
// We need to construct the downstream issuer path from the upstream redirect URI since the two // We need to construct the downstream issuer path from the upstream redirect URI since the two
// are related, and the upstream redirect URI is supplied via a static test environment // are related, and the upstream redirect URI is supplied via a static test environment
@ -145,7 +142,6 @@ func getDownstreamIssuerPathFromUpstreamRedirectURI(t *testing.T, upstreamRedire
return redirectURIPathWithoutLastSegment return redirectURIPathWithoutLastSegment
} }
//nolint:unused
func makeDownstreamAuthURL(t *testing.T, scheme, addr, path string) string { func makeDownstreamAuthURL(t *testing.T, scheme, addr, path string) string {
t.Helper() t.Helper()
downstreamOAuth2Config := oauth2.Config{ downstreamOAuth2Config := oauth2.Config{
@ -167,7 +163,6 @@ func makeDownstreamAuthURL(t *testing.T, scheme, addr, path string) string {
) )
} }
//nolint:unused
func generateAuthRequestParams(t *testing.T) (state.State, nonce.Nonce, pkce.Code) { func generateAuthRequestParams(t *testing.T) (state.State, nonce.Nonce, pkce.Code) {
t.Helper() t.Helper()
state, err := state.Generate() state, err := state.Generate()
@ -179,7 +174,6 @@ func generateAuthRequestParams(t *testing.T) (state.State, nonce.Nonce, pkce.Cod
return state, nonce, pkce return state, nonce, pkce
} }
//nolint:unused
func requireValidRedirectLocation( func requireValidRedirectLocation(
ctx context.Context, ctx context.Context,
t *testing.T, t *testing.T,