From 58a3e35c511856aed5478125d48091a340c7ba72 Mon Sep 17 00:00:00 2001 From: Andrew Keesler Date: Mon, 30 Nov 2020 11:07:25 -0500 Subject: [PATCH] Revert "test/integration: skip TestSupervisorLogin until new callback logic is on main" This reverts commit eae6d355f8ef35ea446839af76bed7a96b072fbb. We have added the new callback path logic (see b21f003), so we can stop skipping this test. --- test/integration/supervisor_login_test.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/test/integration/supervisor_login_test.go b/test/integration/supervisor_login_test.go index ca5c2787..0ce937fb 100644 --- a/test/integration/supervisor_login_test.go +++ b/test/integration/supervisor_login_test.go @@ -28,8 +28,6 @@ import ( ) func TestSupervisorLogin(t *testing.T) { - t.Skip("waiting on new callback path logic to get merged in from the callback endpoint work") - env := library.IntegrationEnv(t) client := library.NewSupervisorClientset(t) @@ -117,7 +115,6 @@ func TestSupervisorLogin(t *testing.T) { } } -//nolint:unused func getDownstreamIssuerPathFromUpstreamRedirectURI(t *testing.T, upstreamRedirectURI string) string { // We need to construct the downstream issuer path from the upstream redirect URI since the two // are related, and the upstream redirect URI is supplied via a static test environment @@ -145,7 +142,6 @@ func getDownstreamIssuerPathFromUpstreamRedirectURI(t *testing.T, upstreamRedire return redirectURIPathWithoutLastSegment } -//nolint:unused func makeDownstreamAuthURL(t *testing.T, scheme, addr, path string) string { t.Helper() downstreamOAuth2Config := oauth2.Config{ @@ -167,7 +163,6 @@ func makeDownstreamAuthURL(t *testing.T, scheme, addr, path string) string { ) } -//nolint:unused func generateAuthRequestParams(t *testing.T) (state.State, nonce.Nonce, pkce.Code) { t.Helper() state, err := state.Generate() @@ -179,7 +174,6 @@ func generateAuthRequestParams(t *testing.T) (state.State, nonce.Nonce, pkce.Cod return state, nonce, pkce } -//nolint:unused func requireValidRedirectLocation( ctx context.Context, t *testing.T,