djpbessems/ContainerImage.Pinniped
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove a "fail fast" check from TestImpersonationProxy.

Browse Source 
This check is no longer valid, because there can be ephemeral, recoverable errors that show as ErrorDuringSetup.

Signed-off-by: Matt Moyer <moyerm@vmware.com>
This commit is contained in:
Matt Moyer 2021-05-27 09:22:47 -05:00
parent d2d0dae4ed
commit 049abfb94c
No known key found for this signature in database
GPG Key ID: EAE88AD172C5AE2D
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/integration/concierge_impersonation_proxy_test.go
View File

@ -1413,10 +1413,6 @@ func performImpersonatorDiscovery(ctx context.Context, t *testing.T, env *librar
} else if strategy.Type == conciergev1alpha.ImpersonationProxyStrategyType { } else if strategy.Type == conciergev1alpha.ImpersonationProxyStrategyType {
t.Logf("Waiting for successful impersonation proxy strategy on %s: found status %s with reason %s and message: %s", t.Logf("Waiting for successful impersonation proxy strategy on %s: found status %s with reason %s and message: %s",
credentialIssuerName(env), strategy.Status, strategy.Reason, strategy.Message) credentialIssuerName(env), strategy.Status, strategy.Reason, strategy.Message)
if strategy.Reason == conciergev1alpha.ErrorDuringSetupStrategyReason {
// The server encountered an unexpected error while starting the impersonator, so fail the test fast.
return false, fmt.Errorf("found impersonation strategy in %s state with message: %s", strategy.Reason, strategy.Message)
}
} }
} }
t.Log("Did not find any impersonation proxy strategy on CredentialIssuer") t.Log("Did not find any impersonation proxy strategy on CredentialIssuer")