From 049abfb94c9414e2d2579ab2cce968048c7d6c18 Mon Sep 17 00:00:00 2001 From: Matt Moyer Date: Thu, 27 May 2021 09:22:47 -0500 Subject: [PATCH] Remove a "fail fast" check from TestImpersonationProxy. This check is no longer valid, because there can be ephemeral, recoverable errors that show as ErrorDuringSetup. Signed-off-by: Matt Moyer --- test/integration/concierge_impersonation_proxy_test.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/test/integration/concierge_impersonation_proxy_test.go b/test/integration/concierge_impersonation_proxy_test.go index 8fff71a7..192db0a4 100644 --- a/test/integration/concierge_impersonation_proxy_test.go +++ b/test/integration/concierge_impersonation_proxy_test.go @@ -1413,10 +1413,6 @@ func performImpersonatorDiscovery(ctx context.Context, t *testing.T, env *librar } else if strategy.Type == conciergev1alpha.ImpersonationProxyStrategyType { t.Logf("Waiting for successful impersonation proxy strategy on %s: found status %s with reason %s and message: %s", credentialIssuerName(env), strategy.Status, strategy.Reason, strategy.Message) - if strategy.Reason == conciergev1alpha.ErrorDuringSetupStrategyReason { - // The server encountered an unexpected error while starting the impersonator, so fail the test fast. - return false, fmt.Errorf("found impersonation strategy in %s state with message: %s", strategy.Reason, strategy.Message) - } } } t.Log("Did not find any impersonation proxy strategy on CredentialIssuer")