Add errorhandling;Fix OU
All checks were successful
continuous-integration/drone/push Build is passing

This commit is contained in:
Danny Bessems 2021-03-27 08:56:26 +01:00
parent 9dfb51db18
commit ed69de5d27
2 changed files with 14 additions and 8 deletions

View File

@ -1,7 +1,7 @@
Name: 'COMP: Restrict Internet Communication' Name: 'COMP: Restrict Internet Communication'
Type: Object Type: Object
LinkedOUs: LinkedOUs:
- OU=Servers - OU=Servers,OU=Computer accounts
WMIFilters: [] WMIFilters: []
RegistryEntries: RegistryEntries:
- Key: HKLM\Software\Policies\Microsoft\InternetManagement - Key: HKLM\Software\Policies\Microsoft\InternetManagement

View File

@ -175,16 +175,22 @@ If (@('primary','standalone') -contains $Parameter['deployment.type']) {
ForEach ($OU in $GroupPolicy.LinkedOUs) { ForEach ($OU in $GroupPolicy.LinkedOUs) {
If (Test-Path "AD:\$($OU + (',{0}' -f (Get-ADRootDSE).rootDomainNamingContext))") { If (Test-Path "AD:\$($OU + (',{0}' -f (Get-ADRootDSE).rootDomainNamingContext))") {
Write-Host "Linking policy '$($NewGPO.DisplayName)' to OU '$($OU)' ..." Try {
$NewGPLinkSplat = @{ Write-Host "Linking policy '$($NewGPO.DisplayName)' to OU '$($OU)' ..."
Name = $NewGPO.DisplayName $NewGPLinkSplat = @{
Target = $OU + (',{0}' -f (Get-ADRootDSE).rootDomainNamingContext) Name = $NewGPO.DisplayName
# ErrorAction = 'SilentlyContinue' Target = $OU + (',{0}' -f (Get-ADRootDSE).rootDomainNamingContext)
}
New-GPLink @NewGPLinkSplat | Out-Null
}
Catch {
$ParseErrors += "Could not link GPO '$($NewGPO.DisplayName)' to OU '$($OU)'"
Continue
} }
New-GPLink @NewGPLinkSplat | Out-Null
} }
Else { Else {
Throw "Path not accessible: 'AD:\$($OU + (',{0}' -f (Get-ADRootDSE).rootDomainNamingContext))" $ParseErrors += "Path not accessible (referred to by '$($NewGPO.DisplayName)'): 'AD:\$($OU + (',{0}' -f (Get-ADRootDSE).rootDomainNamingContext))'"
Continue
} }
} }
} }