From 2de2259c76879ee67f1c1a8ee730c189e6b63b5f Mon Sep 17 00:00:00 2001
From: Danny Bessems <danny@bessems.eu>
Date: Sun, 19 Mar 2023 17:43:29 +0100
Subject: [PATCH] Fix linting faults;Add missing keys

---
 .../workloadcluster/tasks/nodetemplates.yml   |  2 ++
 scripts/Update-OvfConfiguration.bootstrap.yml | 24 +++++++++----------
 2 files changed, 14 insertions(+), 12 deletions(-)

diff --git a/ansible/roles/firstboot/files/ansible_payload/bootstrap/roles/workloadcluster/tasks/nodetemplates.yml b/ansible/roles/firstboot/files/ansible_payload/bootstrap/roles/workloadcluster/tasks/nodetemplates.yml
index 4357da2..7b903c1 100644
--- a/ansible/roles/firstboot/files/ansible_payload/bootstrap/roles/workloadcluster/tasks/nodetemplates.yml
+++ b/ansible/roles/firstboot/files/ansible_payload/bootstrap/roles/workloadcluster/tasks/nodetemplates.yml
@@ -41,6 +41,8 @@
         name: "{{ item.instance.hw_name }}"
         disk:
           - size: 1Gb
+            scsi_controller: 1
+            scsi_type: paravirtual
             unit_number: 1
       when: ova_deploy.results[index] is not skipped
       loop: "{{ ova_deploy.results }}"
diff --git a/scripts/Update-OvfConfiguration.bootstrap.yml b/scripts/Update-OvfConfiguration.bootstrap.yml
index 4b74c10..caa0dac 100644
--- a/scripts/Update-OvfConfiguration.bootstrap.yml
+++ b/scripts/Update-OvfConfiguration.bootstrap.yml
@@ -128,8 +128,8 @@ PropertyCategories:
     Description: ''
     DefaultValue: 'workload-{{ hostname.suffix }}'
     Configurations:
-      - cp1w1
-      - cp1w2
+    - cp1w1
+    - cp1w2
     UserConfigurable: true
 
   - Key: workloadcluster.vip
@@ -138,8 +138,8 @@ PropertyCategories:
     Description: Workload-cluster control plane endpoint virtual IP address
     DefaultValue: ''
     Configurations:
-      - cp1w1
-      - cp1w2
+    - cp1w1
+    - cp1w2
     UserConfigurable: true
 
   - Key: ippool.startip
@@ -148,8 +148,8 @@ PropertyCategories:
     Description: All nodes for the workload-cluster will be provisioned within this IP pool
     DefaultValue: ''
     Configurations:
-      - cp1w1
-      - cp1w2
+    - cp1w1
+    - cp1w2
     UserConfigurable: true
 
   - Key: ippool.endip
@@ -158,8 +158,8 @@ PropertyCategories:
     Description: All nodes for the workload-cluster will be provisioned within this IP pool
     DefaultValue: ''
     Configurations:
-      - cp1w1
-      - cp1w2
+    - cp1w1
+    - cp1w2
     UserConfigurable: true
 
   - Key: workloadcluster.nodesize
@@ -171,8 +171,8 @@ PropertyCategories:
       - MEDIUM: 4 vCPU/8GB RAM
     DefaultValue: 'small'
     Configurations:
-      - cp1w1
-      - cp1w2
+    - cp1w1
+    - cp1w2
     UserConfigurable: true
 
   - Key: workloadcluster.additionaldisk
@@ -181,8 +181,8 @@ PropertyCategories:
     Description: 'All worker-nodes for the workload-cluster will be provisioned with an additional disk of the specified size'
     DefaultValue: '20'
     Configurations:
-      - cp1w1
-      - cp1w2
+    - cp1w1
+    - cp1w2
     UserConfigurable: true
 
 - Name: 4) Common