cd686ffdf3
This change updates the TLS config used by all pinniped components. There are no configuration knobs associated with this change. Thus this change tightens our static defaults. There are four TLS config levels: 1. Secure (TLS 1.3 only) 2. Default (TLS 1.2+ best ciphers that are well supported) 3. Default LDAP (TLS 1.2+ with less good ciphers) 4. Legacy (currently unused, TLS 1.2+ with all non-broken ciphers) Highlights per component: 1. pinniped CLI - uses "secure" config against KAS - uses "default" for all other connections 2. concierge - uses "secure" config as an aggregated API server - uses "default" config as a impersonation proxy API server - uses "secure" config against KAS - uses "default" config for JWT authenticater (mostly, see code) - no changes to webhook authenticater (see code) 3. supervisor - uses "default" config as a server - uses "secure" config against KAS - uses "default" config against OIDC IDPs - uses "default LDAP" config against LDAP IDPs Signed-off-by: Monis Khan <mok@vmware.com>
129 lines
2.9 KiB
Go
129 lines
2.9 KiB
Go
// Copyright 2020-2021 the Pinniped contributors. All Rights Reserved.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package plog
|
|
|
|
import (
|
|
"strconv"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"k8s.io/component-base/logs"
|
|
"k8s.io/klog/v2"
|
|
)
|
|
|
|
func TestValidateAndSetLogLevelGlobally(t *testing.T) {
|
|
originalLogLevel := getKlogLevel()
|
|
require.GreaterOrEqual(t, int(originalLogLevel), int(klog.Level(0)), "cannot get klog level")
|
|
|
|
tests := []struct {
|
|
name string
|
|
level LogLevel
|
|
wantLevel klog.Level
|
|
wantEnabled []LogLevel
|
|
wantErr string
|
|
}{
|
|
{
|
|
name: "unset",
|
|
wantLevel: 0,
|
|
wantEnabled: []LogLevel{LevelWarning},
|
|
},
|
|
{
|
|
name: "warning",
|
|
level: LevelWarning,
|
|
wantLevel: 0,
|
|
wantEnabled: []LogLevel{LevelWarning},
|
|
},
|
|
{
|
|
name: "info",
|
|
level: LevelInfo,
|
|
wantLevel: 2,
|
|
wantEnabled: []LogLevel{LevelWarning, LevelInfo},
|
|
},
|
|
{
|
|
name: "debug",
|
|
level: LevelDebug,
|
|
wantLevel: 4,
|
|
wantEnabled: []LogLevel{LevelWarning, LevelInfo, LevelDebug},
|
|
},
|
|
{
|
|
name: "trace",
|
|
level: LevelTrace,
|
|
wantLevel: 6,
|
|
wantEnabled: []LogLevel{LevelWarning, LevelInfo, LevelDebug, LevelTrace},
|
|
},
|
|
{
|
|
name: "all",
|
|
level: LevelAll,
|
|
wantLevel: 108,
|
|
wantEnabled: []LogLevel{LevelWarning, LevelInfo, LevelDebug, LevelTrace, LevelAll},
|
|
},
|
|
{
|
|
name: "invalid level",
|
|
level: "panda",
|
|
wantLevel: originalLogLevel,
|
|
wantErr: errInvalidLogLevel.Error(),
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
tt := tt // capture range variable
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
defer func() {
|
|
undoGlobalLogLevelChanges(t, originalLogLevel)
|
|
}()
|
|
|
|
err := ValidateAndSetLogLevelGlobally(tt.level)
|
|
require.Equal(t, tt.wantErr, errString(err))
|
|
require.Equal(t, tt.wantLevel, getKlogLevel())
|
|
|
|
if tt.wantEnabled != nil {
|
|
allLevels := []LogLevel{LevelWarning, LevelInfo, LevelDebug, LevelTrace, LevelAll}
|
|
for _, level := range allLevels {
|
|
if contains(tt.wantEnabled, level) {
|
|
require.Truef(t, Enabled(level), "wanted %q to be enabled", level)
|
|
} else {
|
|
require.False(t, Enabled(level), "did not want %q to be enabled", level)
|
|
}
|
|
}
|
|
}
|
|
})
|
|
}
|
|
|
|
require.Equal(t, originalLogLevel, getKlogLevel())
|
|
}
|
|
|
|
func contains(haystack []LogLevel, needle LogLevel) bool {
|
|
for _, hay := range haystack {
|
|
if hay == needle {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
func errString(err error) string {
|
|
if err == nil {
|
|
return ""
|
|
}
|
|
|
|
return err.Error()
|
|
}
|
|
|
|
func undoGlobalLogLevelChanges(t *testing.T, originalLogLevel klog.Level) {
|
|
t.Helper()
|
|
_, err := logs.GlogSetter(strconv.Itoa(int(originalLogLevel)))
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func getKlogLevel() klog.Level {
|
|
// hack around klog not exposing a Get method
|
|
for i := klog.Level(0); i < 256; i++ {
|
|
if klog.V(i).Enabled() {
|
|
continue
|
|
}
|
|
return i - 1
|
|
}
|
|
|
|
return -1
|
|
}
|