efe1fa89fe
Yes, this is a huge commit.
The middleware allows you to customize the API groups of all of the
*.pinniped.dev API groups.
Some notes about other small things in this commit:
- We removed the internal/client package in favor of pkg/conciergeclient. The
two packages do basically the same thing. I don't think we use the former
anymore.
- We re-enabled cluster-scoped owner assertions in the integration tests.
This code was added in internal/ownerref. See a0546942 for when this
assertion was removed.
- Note: the middlware code is in charge of restoring the GV of a request object,
so we should never need to write mutations that do that.
- We updated the supervisor secret generation to no longer manually set an owner
reference to the deployment since the middleware code now does this. I think we
still need some way to make an initial event for the secret generator
controller, which involves knowing the namespace and the name of the generated
secret, so I still wired the deployment through. We could use a namespace/name
tuple here, but I was lazy.
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
Co-authored-by: Ryan Richard <richardry@vmware.com>
128 lines
3.0 KiB
Go
128 lines
3.0 KiB
Go
// Copyright 2021 the Pinniped contributors. All Rights Reserved.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package deploymentref
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
appsv1 "k8s.io/api/apps/v1"
|
|
corev1 "k8s.io/api/core/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
"k8s.io/client-go/kubernetes"
|
|
kubefake "k8s.io/client-go/kubernetes/fake"
|
|
kubetesting "k8s.io/client-go/testing"
|
|
|
|
"go.pinniped.dev/internal/downward"
|
|
)
|
|
|
|
func TestNew(t *testing.T) {
|
|
troo := true
|
|
goodDeployment := &appsv1.Deployment{
|
|
TypeMeta: metav1.TypeMeta{
|
|
APIVersion: "apps/v1",
|
|
Kind: "Deployment",
|
|
},
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "some-namespace",
|
|
Name: "some-name",
|
|
},
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
apiObjects []runtime.Object
|
|
client func(*kubefake.Clientset)
|
|
createClientErr error
|
|
podInfo *downward.PodInfo
|
|
wantDeployment *appsv1.Deployment
|
|
wantError string
|
|
}{
|
|
{
|
|
name: "happy",
|
|
apiObjects: []runtime.Object{
|
|
goodDeployment,
|
|
&appsv1.ReplicaSet{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "some-namespace",
|
|
Name: "some-name-rsname",
|
|
OwnerReferences: []metav1.OwnerReference{
|
|
{
|
|
Controller: &troo,
|
|
Name: "some-name",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
&corev1.Pod{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "some-namespace",
|
|
Name: "some-name-rsname-podhash",
|
|
OwnerReferences: []metav1.OwnerReference{
|
|
{
|
|
Controller: &troo,
|
|
Name: "some-name-rsname",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
podInfo: &downward.PodInfo{
|
|
Namespace: "some-namespace",
|
|
Name: "some-name-rsname-podhash",
|
|
},
|
|
wantDeployment: goodDeployment,
|
|
},
|
|
{
|
|
name: "failed to create client",
|
|
createClientErr: errors.New("some create error"),
|
|
podInfo: &downward.PodInfo{
|
|
Namespace: "some-namespace",
|
|
Name: "some-name-rsname-podhash",
|
|
},
|
|
wantError: "cannot create temp client: some create error",
|
|
},
|
|
{
|
|
name: "failed to talk to api",
|
|
client: func(c *kubefake.Clientset) {
|
|
c.PrependReactor(
|
|
"get",
|
|
"pods",
|
|
func(_ kubetesting.Action) (bool, runtime.Object, error) {
|
|
return true, nil, errors.New("get failed")
|
|
},
|
|
)
|
|
},
|
|
podInfo: &downward.PodInfo{
|
|
Namespace: "some-namespace",
|
|
Name: "some-name-rsname-podhash",
|
|
},
|
|
wantError: "cannot get deployment: could not get pod: get failed",
|
|
},
|
|
}
|
|
for _, test := range tests {
|
|
test := test
|
|
t.Run(test.name, func(t *testing.T) {
|
|
client := kubefake.NewSimpleClientset(test.apiObjects...)
|
|
if test.client != nil {
|
|
test.client(client)
|
|
}
|
|
|
|
getTempClient = func() (kubernetes.Interface, error) {
|
|
return client, test.createClientErr
|
|
}
|
|
|
|
_, d, err := New(test.podInfo)
|
|
if test.wantError != "" {
|
|
require.EqualError(t, err, test.wantError)
|
|
return
|
|
}
|
|
|
|
require.NoError(t, err)
|
|
require.Equal(t, test.wantDeployment, d)
|
|
})
|
|
}
|
|
}
|