d8c6894cbc
All controller unit tests were accidentally using a timeout context for the informers, instead of a cancel context which stays alive until each test is completely finished. There is no reason to risk unpredictable behavior of a timeout being reached during an individual test, even though with the previous 3 second timeout it could only be reached on a machine which is running orders of magnitude slower than usual, since each test usually runs in about 100-300 ms. Unfortunately, sometimes our CI workers might get that slow. This sparked a review of other usages of timeout contexts in other tests, and all of them were increased to a minimum value of 1 minute, under the rule of thumb that our tests will be more reliable on slow machines if they "pass fast and fail slow". |
||
|---|---|---|
| .. | ||
| browsertest | ||
| access.go | ||
| assertions.go | ||
| cli.go | ||
| client.go | ||
| dumplogs.go | ||
| env.go | ||
| iotest.go | ||
| iplookup.go | ||
| iplookup_go1.14.go | ||
| skip.go | ||
| spew.go | ||