ContainerImage.Pinniped/internal
Ryan Richard 08961919b5 Fix a garbage collection bug
- Previously the golang code would create a Service and an APIService.
  The APIService would be given an owner reference which pointed to
  the namespace in which the app was installed.
- This prevented the app from being uninstalled. The namespace would
  refuse to delete, so `kapp delete` or `kubectl delete` would fail.
- The new approach is to statically define the Service and an APIService
  in the deployment.yaml, except for the caBundle of the APIService.
  Then the golang code will perform an update to add the caBundle at
  runtime.
- When the user uses `kapp deploy` or `kubectl apply` either tool will
  notice that the caBundle is not declared in the yaml and will
  therefore avoid editing that field.
- When the user uses `kapp delete` or `kubectl delete` either tool will
  destroy the objects because they are statically declared with names
  in the yaml, just like all of the other objects. There are no
  ownerReferences used, so nothing should prevent the namespace from
  being deleted.
- This approach also allows us to have less golang code to maintain.
- In the future, if our golang controllers want to dynamically add
  an Ingress or other objects, they can still do that. An Ingress
  would point to our statically defined Service as its backend.

Signed-off-by: Andrew Keesler <akeesler@vmware.com>
2020-08-04 16:46:27 -07:00
..
apiserver More WIP for the publisher controller 2020-07-31 14:35:20 -07:00
autoregistration Fix a garbage collection bug 2020-08-04 16:46:27 -07:00
certauthority Fix linter error in certauthority. 2020-07-27 12:33:33 -07:00
constable Add placeholder-name CLI 2020-07-28 15:15:59 -05:00
controller/logindiscovery Allow override of discovery URL via ConfigMap 2020-08-03 10:17:11 -04:00
downward Add a package for loading Downward API metadata. 2020-07-16 14:25:23 -05:00
mocks/mockcertissuer Add generated mock for loginrequest.CertIssuer interface. 2020-07-27 12:33:33 -07:00
registry/loginrequest Use the correct field when encoding groups into the certificate. 2020-08-03 17:31:18 -05:00
server Fix a garbage collection bug 2020-08-04 16:46:27 -07:00