efe1fa89fe
Yes, this is a huge commit.
The middleware allows you to customize the API groups of all of the
*.pinniped.dev API groups.
Some notes about other small things in this commit:
- We removed the internal/client package in favor of pkg/conciergeclient. The
two packages do basically the same thing. I don't think we use the former
anymore.
- We re-enabled cluster-scoped owner assertions in the integration tests.
This code was added in internal/ownerref. See a0546942
for when this
assertion was removed.
- Note: the middlware code is in charge of restoring the GV of a request object,
so we should never need to write mutations that do that.
- We updated the supervisor secret generation to no longer manually set an owner
reference to the deployment since the middleware code now does this. I think we
still need some way to make an initial event for the secret generator
controller, which involves knowing the namespace and the name of the generated
secret, so I still wired the deployment through. We could use a namespace/name
tuple here, but I was lazy.
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
Co-authored-by: Ryan Richard <richardry@vmware.com>
143 lines
4.3 KiB
Go
143 lines
4.3 KiB
Go
// Copyright 2021 the Pinniped contributors. All Rights Reserved.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
package groupsuffix
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/runtime/schema"
|
|
"k8s.io/apimachinery/pkg/util/validation"
|
|
|
|
"go.pinniped.dev/internal/constable"
|
|
"go.pinniped.dev/internal/kubeclient"
|
|
"go.pinniped.dev/internal/multierror"
|
|
)
|
|
|
|
const (
|
|
pinnipedDefaultSuffix = "pinniped.dev"
|
|
pinnipedDefaultSuffixWithDot = ".pinniped.dev"
|
|
)
|
|
|
|
func New(apiGroupSuffix string) kubeclient.Middleware {
|
|
// return a no-op middleware by default
|
|
if len(apiGroupSuffix) == 0 || apiGroupSuffix == pinnipedDefaultSuffix {
|
|
return nil
|
|
}
|
|
|
|
return kubeclient.Middlewares{
|
|
kubeclient.MiddlewareFunc(func(_ context.Context, rt kubeclient.RoundTrip) {
|
|
group := rt.Resource().Group
|
|
newGroup, ok := Replace(group, apiGroupSuffix)
|
|
if !ok {
|
|
return // ignore APIs that do not have our group
|
|
}
|
|
|
|
rt.MutateRequest(func(obj kubeclient.Object) {
|
|
typeMeta := obj.GetObjectKind()
|
|
origGVK := typeMeta.GroupVersionKind()
|
|
newGVK := schema.GroupVersionKind{
|
|
Group: newGroup,
|
|
Version: origGVK.Version,
|
|
Kind: origGVK.Kind,
|
|
}
|
|
typeMeta.SetGroupVersionKind(newGVK)
|
|
})
|
|
}),
|
|
|
|
kubeclient.MiddlewareFunc(func(_ context.Context, rt kubeclient.RoundTrip) {
|
|
// we should not mess with owner refs on things we did not create
|
|
if rt.Verb() != kubeclient.VerbCreate {
|
|
return
|
|
}
|
|
|
|
// we probably do not want mess with an owner ref on a subresource
|
|
if len(rt.Subresource()) != 0 {
|
|
return
|
|
}
|
|
|
|
rt.MutateRequest(mutateOwnerRefs(Replace, apiGroupSuffix))
|
|
}),
|
|
|
|
kubeclient.MiddlewareFunc(func(_ context.Context, rt kubeclient.RoundTrip) {
|
|
// always unreplace owner refs with apiGroupSuffix because we can consume those objects across all verbs
|
|
rt.MutateResponse(mutateOwnerRefs(unreplace, apiGroupSuffix))
|
|
}),
|
|
}
|
|
}
|
|
|
|
func mutateOwnerRefs(replaceFunc func(baseAPIGroup, apiGroupSuffix string) (string, bool), apiGroupSuffix string) func(kubeclient.Object) {
|
|
return func(obj kubeclient.Object) {
|
|
// fix up owner refs because they are consumed by external and internal actors
|
|
oldRefs := obj.GetOwnerReferences()
|
|
if len(oldRefs) == 0 {
|
|
return
|
|
}
|
|
|
|
var changedGroup bool
|
|
|
|
newRefs := make([]metav1.OwnerReference, 0, len(oldRefs))
|
|
for _, ref := range oldRefs {
|
|
ref := *ref.DeepCopy()
|
|
|
|
gv, _ := schema.ParseGroupVersion(ref.APIVersion) // error is safe to ignore, empty gv is fine
|
|
|
|
if newGroup, ok := replaceFunc(gv.Group, apiGroupSuffix); ok {
|
|
changedGroup = true
|
|
gv.Group = newGroup
|
|
ref.APIVersion = gv.String()
|
|
}
|
|
|
|
newRefs = append(newRefs, ref)
|
|
}
|
|
|
|
if !changedGroup {
|
|
return
|
|
}
|
|
|
|
obj.SetOwnerReferences(newRefs)
|
|
}
|
|
}
|
|
|
|
// Replace constructs an API group from a baseAPIGroup and a parameterized apiGroupSuffix.
|
|
//
|
|
// We assume that all baseAPIGroup's will end in "pinniped.dev", and therefore we can safely replace
|
|
// the reference to "pinniped.dev" with the provided apiGroupSuffix. If the provided baseAPIGroup
|
|
// does not end in "pinniped.dev", then this function will return an empty string and false.
|
|
//
|
|
// See ExampleReplace_loginv1alpha1 and ExampleReplace_string for more information on input/output pairs.
|
|
func Replace(baseAPIGroup, apiGroupSuffix string) (string, bool) {
|
|
if !strings.HasSuffix(baseAPIGroup, pinnipedDefaultSuffixWithDot) {
|
|
return "", false
|
|
}
|
|
return strings.TrimSuffix(baseAPIGroup, pinnipedDefaultSuffix) + apiGroupSuffix, true
|
|
}
|
|
|
|
func unreplace(baseAPIGroup, apiGroupSuffix string) (string, bool) {
|
|
if !strings.HasSuffix(baseAPIGroup, "."+apiGroupSuffix) {
|
|
return "", false
|
|
}
|
|
return strings.TrimSuffix(baseAPIGroup, apiGroupSuffix) + pinnipedDefaultSuffix, true
|
|
}
|
|
|
|
// Validate validates the provided apiGroupSuffix is usable as an API group suffix. Specifically, it
|
|
// makes sure that the provided apiGroupSuffix is a valid DNS-1123 subdomain with at least one dot,
|
|
// to match Kubernetes behavior.
|
|
func Validate(apiGroupSuffix string) error {
|
|
err := multierror.New()
|
|
|
|
if len(strings.Split(apiGroupSuffix, ".")) < 2 {
|
|
err.Add(constable.Error("must contain '.'"))
|
|
}
|
|
|
|
errorStrings := validation.IsDNS1123Subdomain(apiGroupSuffix)
|
|
for _, errorString := range errorStrings {
|
|
errorString := errorString
|
|
err.Add(constable.Error(errorString))
|
|
}
|
|
|
|
return err.ErrOrNil()
|
|
}
|