Ryan Richard
09571d1117
Merge pull request #33 from cfryanr/discovery_doc
...
Adding discovery document object
2020-08-04 10:01:20 -07:00
Matt Moyer
573202140d
Merge pull request #39 from mattmoyer/fix-certificate-group-field
...
Fix group identity encoding in client certificates.
2020-08-03 17:46:31 -05:00
Matt Moyer
fdbc30365d
Use the correct field when encoding groups into the certificate.
...
Signed-off-by: Matt Moyer <moyerm@vmware.com>
2020-08-03 17:31:18 -05:00
Matt Moyer
b70c62a1b3
Add a test case to TestSuccessfulLoginRequest to verify access as group.
...
Signed-off-by: Matt Moyer <moyerm@vmware.com>
2020-08-03 17:29:55 -05:00
Andrew Keesler
2b9d2ca293
Merge remote-tracking branch 'upstream/main' into discovery_doc
2020-08-03 14:47:56 -04:00
Andrew Keesler
12120d7e8b
Force CI to run.
2020-08-03 14:45:39 -04:00
Ryan Richard
727a5883f2
Bring over ytt values.yaml update from discovery PR
...
- We are temporarily adding this change on the main branch so that CI works
with the main branch and we can iterate on our changes on our PR branch.
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
2020-08-03 14:40:18 -04:00
Ryan Richard
ca80d87dcf
Use rest.Config for discovery URL instead of env var
...
- Why? Because the discovery URL is already there in the kubeconfig; let's
not make our lives more complicated by passing it in via an env var.
- Also allow for ytt callers to not specify data.values.discovery_url - there
are going to be a non-trivial number of installers of placeholder-name
that want to use the server URL found in the cluster-info ConfigMap.
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
2020-08-03 14:36:08 -04:00
Andrew Keesler
e884cef1ef
Resolve SingularName TODO with comment
...
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
2020-08-03 10:29:59 -04:00
Andrew Keesler
597408a977
Allow override of discovery URL via ConfigMap
...
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
- Seems like the next step is to allow override of the CA bundle; I didn't
do that here for simplicity of the commit, but seems like it is the right
thing to do in the future.
2020-08-03 10:17:11 -04:00
Ryan Richard
548874a641
Move TestGetAPIResourceList to its own file
...
Because it is now testing multiple api types
2020-07-31 17:37:59 -07:00
Ryan Richard
cf56c67329
Move LoginDiscoveryConfig to the crds.placeholder.suzerain-io.github.io group
...
- Also includes bumping the api and client-go dependencies to the newer
version which also moved LoginDiscoveryConfig to the
crds.placeholder.suzerain-io.github.io group in the generated code
2020-07-31 17:22:12 -07:00
Ryan Richard
9fe82ec5f1
Merge remote-tracking branch 'upstream/main' into discovery_doc
2020-07-31 16:38:40 -07:00
Ryan Richard
2aa80e3576
More WIP for the publisher controller
2020-07-31 14:35:20 -07:00
aram price
0f248768a3
Merge pull request #37 from suzerain-io/update-api-and-client-go
...
Update -api and -client-go dependencies
2020-07-31 13:40:46 -07:00
Andrew Keesler
52546fad90
WIP: start on publisher controller integration
2020-07-31 12:08:07 -04:00
aram price
bd594e19ff
Update -api and -client-go dependencies
...
- pulls in chage to make ExpirationTimestamp mandatory on
LoginRequestCredential
2020-07-30 20:05:32 -07:00
Ryan Richard
2e05e032ee
Merge remote-tracking branch 'upstream/main' into discovery_doc
2020-07-30 17:28:35 -07:00
Ryan Richard
733f80b7ae
Apply filters to PublisherController
...
- Ask the controller package to only call the Sync() method for
the specific objects in which this controller is interested
2020-07-30 17:16:09 -07:00
Andrew Keesler
ae7be3ea94
Merge pull request #31 from ankeesler/duplicate-header-definition
...
Consolidate duplicate header definitions
2020-07-30 18:01:49 -04:00
Andrew Keesler
a8dbdfd1c4
Consolidate duplicate header definitions
...
See 6dfae48b65
.
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
2020-07-30 17:59:03 -04:00
Matt Moyer
3d293c96bc
Merge pull request #36 from mattmoyer/fix-expiration-handling
...
Fix expiration timestamp handling
2020-07-30 16:55:52 -05:00
Matt Moyer
02c17d875e
Update the LoginRequest server to return an expiration timestamp.
...
Signed-off-by: Matt Moyer <moyerm@vmware.com>
2020-07-30 16:43:20 -05:00
Matt Moyer
076f8805d2
Update integration tests to assert a non-nil expiration timestamp.
...
Signed-off-by: Matt Moyer <moyerm@vmware.com>
2020-07-30 16:41:12 -05:00
Ryan Richard
5aebb76146
Make the PublisherController use informers
...
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
2020-07-30 14:34:13 -07:00
Matt Moyer
ec6ec2abe9
Handle expiration and token fields in client package.
...
Signed-off-by: Matt Moyer <moyerm@vmware.com>
2020-07-30 16:25:59 -05:00
Matt Moyer
b59604b47c
Merge pull request #34 from mattmoyer/reduced-dependency-client
...
Reduce the dependencies of the ./pkg/client package.
2020-07-30 14:45:20 -05:00
Matt Moyer
66fe580e99
We need an extra "go test" command for the new pkg/client module.
...
Signed-off-by: Matt Moyer <moyerm@vmware.com>
2020-07-30 14:00:06 -05:00
Matt Moyer
a448b3474e
Add some missing test cases for pkg/client.
...
Signed-off-by: Matt Moyer <moyerm@vmware.com>
2020-07-30 13:49:45 -05:00
Matt Moyer
04cacabc16
Convert pkg/client to depend only on stdlib.
...
Signed-off-by: Matt Moyer <moyerm@vmware.com>
2020-07-30 13:49:45 -05:00
Matt Moyer
3bc0389bab
Add some missing assertions in pkg/client/client_test.go.
...
Signed-off-by: Matt Moyer <moyerm@vmware.com>
2020-07-30 13:49:45 -05:00
Matt Moyer
15bee7456c
Merge pull request #35 from mattmoyer/add-hack-test-script
...
Add ./hack/test-unit.sh.
2020-07-30 13:49:28 -05:00
Matt Moyer
8bdf05dae4
Add ./hack/test-unit.sh.
...
Our unit test command is going to get slighly more complex in a future revision. This should let us avoid having to sync the CI pipeline definition so many times.
Signed-off-by: Matt Moyer <moyerm@vmware.com>
2020-07-30 13:28:27 -05:00
Andrew Keesler
ee865fe97f
logindiscovery: add package documentation.
...
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
2020-07-30 11:18:49 -04:00
Andrew Keesler
9a859875a7
logindiscovery: add tests for conditional update and error cases
...
- Also add some log lines for better observability of behavior.
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
2020-07-30 10:39:15 -04:00
Ryan Richard
e0cac97084
More tests for the PublisherController
...
- Also, don't repeat `spec.Parallel()` because, according to the docs
for the spec package, "options are inherited by subgroups and subspecs"
- Two tests are left pending to be filled in on the next commit
2020-07-29 18:18:42 -07:00
Andrew Keesler
a5f7de429d
First commit of PublisherController
...
- Also upgrade go-client and api dependencies, and add controller-go as a dependency
Signed-off-by: Ryan Richard <richardry@vmware.com>
2020-07-29 17:22:25 -07:00
Ryan Richard
aa90173891
Merge branch 'main' into discovery_doc
2020-07-29 13:56:21 -07:00
Andrew Keesler
409462e989
Remove the controller pkg because it was moved to another repo
...
Signed-off-by: Ryan Richard <richardry@vmware.com>
2020-07-29 13:53:40 -07:00
Ryan Richard
a8f3c62d37
Remove identity provider list from LoginDiscoveryConfig CRD
...
Because we're not going to need it for the current story
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
2020-07-29 13:17:55 -07:00
Andrew Keesler
7ba43e0c3f
More validations on the LoginDiscoveryConfig CRD
...
Signed-off-by: Ryan Richard <richardry@vmware.com>
2020-07-29 13:14:50 -07:00
Ryan Richard
43c3f1ab2e
Minor test cleanup
...
- `Before` gives a nice place to call `require.New(t)` to make the assertion lines more terse
- Just delete the keys for testing when env vars are missing
2020-07-28 17:22:17 -07:00
Ryan Richard
b70f3aefe5
First draft of LoginDiscoveryConfig CRD
2020-07-28 16:55:50 -07:00
Matt Moyer
1e56ecfdb4
Merge pull request #32 from mattmoyer/fix-cli-bug
...
Fix a bug in placeholder-name CLI (wrong API version).
2020-07-28 16:22:25 -05:00
Matt Moyer
42616e7d8a
Fix a bug in placeholder-name CLI (wrong API version).
...
This is kind of a subtle bug, but we were using the unversioned Kubernetes type package here, where we should have been using the v1beta1 version. They have the same fields, but they serialize to JSON differently.
Signed-off-by: Matt Moyer <moyerm@vmware.com>
2020-07-28 16:10:27 -05:00
Matt Moyer
271eb9b837
Merge pull request #30 from cfryanr/new_cli
...
Create a client CLI command
2020-07-28 15:29:13 -05:00
Matt Moyer
48433eb36b
Add integration tests for the client package.
...
Signed-off-by: Matt Moyer <moyerm@vmware.com>
2020-07-28 15:15:59 -05:00
aram price
bc4351f51a
Add copyright, appease the linter
2020-07-28 15:15:59 -05:00
Matt Moyer
531954511b
Extract a test library helper for ErrorWriter{}.
...
Signed-off-by: Matt Moyer <moyerm@vmware.com>
2020-07-28 15:15:59 -05:00
Matt Moyer
a15a106fd3
Add a trailing newline to our CLI error output.
...
Signed-off-by: Matt Moyer <moyerm@vmware.com>
2020-07-28 15:15:59 -05:00