djpbessems/ContainerImage.Pinniped
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Resolve SingularName TODO with comment

Browse Source 
Signed-off-by: Andrew Keesler <akeesler@vmware.com>
This commit is contained in:
Andrew Keesler 2020-08-03 10:29:54 -04:00
parent 597408a977
commit e884cef1ef
No known key found for this signature in database
GPG Key ID: 27CE0444346F9413
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/integration/api_discovery_test.go
View File

@ -47,11 +47,15 @@ func TestGetAPIResourceList(t *testing.T) {
expectedLoginRequestAPIResource := metav1.APIResource{ expectedLoginRequestAPIResource := metav1.APIResource{
Name: "loginrequests", Name: "loginrequests",
Kind: "LoginRequest", Kind: "LoginRequest",
SingularName: "", // TODO(akeesler): what should this be?
Verbs: metav1.Verbs([]string{ Verbs: metav1.Verbs([]string{
"create", "create",
}), }),
Namespaced: false, Namespaced: false,
// This is currently an empty string in the response; maybe it should not be
// empty? Seems like no harm in keeping it like this for now, but feel free
// to update in the future if there is a compelling reason to do so.
SingularName: "",
} }
expectedLDCAPIResource := metav1.APIResource{ expectedLDCAPIResource := metav1.APIResource{