Merge pull request #136 from ankeesler/pinniped-version-command
cmd/pinniped: add version command
This commit is contained in:
commit
d23ff1f5eb
28
cmd/pinniped/cmd/version.go
Normal file
28
cmd/pinniped/cmd/version.go
Normal file
@ -0,0 +1,28 @@
|
|||||||
|
// Copyright 2020 the Pinniped contributors. All Rights Reserved.
|
||||||
|
// SPDX-License-Identifier: Apache-2.0
|
||||||
|
|
||||||
|
package cmd
|
||||||
|
|
||||||
|
import (
|
||||||
|
"fmt"
|
||||||
|
|
||||||
|
"github.com/spf13/cobra"
|
||||||
|
"k8s.io/component-base/version"
|
||||||
|
)
|
||||||
|
|
||||||
|
//nolint: gochecknoinits
|
||||||
|
func init() {
|
||||||
|
rootCmd.AddCommand(newVersionCommand())
|
||||||
|
}
|
||||||
|
|
||||||
|
func newVersionCommand() *cobra.Command {
|
||||||
|
return &cobra.Command{
|
||||||
|
RunE: func(cmd *cobra.Command, _ []string) error {
|
||||||
|
fmt.Fprintf(cmd.OutOrStdout(), "%#v\n", version.Get())
|
||||||
|
return nil
|
||||||
|
},
|
||||||
|
Args: cobra.NoArgs, // do not accept positional arguments for this command
|
||||||
|
Use: "version",
|
||||||
|
Short: "Print the version of this Pinniped CLI",
|
||||||
|
}
|
||||||
|
}
|
85
cmd/pinniped/cmd/version_test.go
Normal file
85
cmd/pinniped/cmd/version_test.go
Normal file
@ -0,0 +1,85 @@
|
|||||||
|
// Copyright 2020 the Pinniped contributors. All Rights Reserved.
|
||||||
|
// SPDX-License-Identifier: Apache-2.0
|
||||||
|
|
||||||
|
package cmd
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bytes"
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"github.com/stretchr/testify/require"
|
||||||
|
|
||||||
|
"go.pinniped.dev/internal/here"
|
||||||
|
)
|
||||||
|
|
||||||
|
var (
|
||||||
|
knownGoodUsageRegexpForVersion = here.Doc(`
|
||||||
|
Usage:
|
||||||
|
version \[flags\]
|
||||||
|
|
||||||
|
Flags:
|
||||||
|
-h, --help help for version
|
||||||
|
|
||||||
|
`)
|
||||||
|
|
||||||
|
knownGoodHelpRegexpForVersion = here.Doc(`
|
||||||
|
Print the version of this Pinniped CLI
|
||||||
|
|
||||||
|
Usage:
|
||||||
|
version \[flags\]
|
||||||
|
|
||||||
|
Flags:
|
||||||
|
-h, --help help for version
|
||||||
|
`)
|
||||||
|
|
||||||
|
emptyVersionRegexp = `version.Info{Major:"", Minor:"", GitVersion:".*", GitCommit:".*", GitTreeState:"", BuildDate:".*", GoVersion:".*", Compiler:".*", Platform:".*/.*"}`
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestNewVersionCmd(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
tests := []struct {
|
||||||
|
name string
|
||||||
|
args []string
|
||||||
|
wantError bool
|
||||||
|
wantStdoutRegexp string
|
||||||
|
wantStderr string
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
name: "no flags",
|
||||||
|
args: []string{},
|
||||||
|
wantStdoutRegexp: emptyVersionRegexp + "\n",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "help flag passed",
|
||||||
|
args: []string{"--help"},
|
||||||
|
wantStdoutRegexp: knownGoodHelpRegexpForVersion,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "arg passed",
|
||||||
|
args: []string{"tuna"},
|
||||||
|
wantError: true,
|
||||||
|
wantStdoutRegexp: `Error: unknown command "tuna" for "version"` + "\n" + knownGoodUsageRegexpForVersion,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
for _, tt := range tests {
|
||||||
|
tt := tt
|
||||||
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
cmd := newVersionCommand()
|
||||||
|
require.NotNil(t, cmd)
|
||||||
|
|
||||||
|
var stdout, stderr bytes.Buffer
|
||||||
|
cmd.SetOut(&stdout)
|
||||||
|
cmd.SetErr(&stderr)
|
||||||
|
cmd.SetArgs(tt.args)
|
||||||
|
err := cmd.Execute()
|
||||||
|
if tt.wantError {
|
||||||
|
require.Error(t, err)
|
||||||
|
} else {
|
||||||
|
require.NoError(t, err)
|
||||||
|
}
|
||||||
|
require.Regexp(t, tt.wantStdoutRegexp, stdout.String(), "unexpected stdout")
|
||||||
|
require.Equal(t, tt.wantStderr, stderr.String(), "unexpected stderr")
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
Loading…
Reference in New Issue
Block a user