From d0b37a7c90c10ab143a34a3cf688dcf85462cad1 Mon Sep 17 00:00:00 2001
From: Matt Moyer <moyerm@vmware.com>
Date: Thu, 8 Jul 2021 20:15:14 -0500
Subject: [PATCH] Adjust TestFormPostHTML to work on Linux chromedriver.

For some reason our headless Chrome test setup behaves slightly differently on Linux and macOS hosts. On Linux, the emoji characters are not recognized as valid text, so they are URL encoded. This change updates the test to cope with both cases correctly.

Signed-off-by: Matt Moyer <moyerm@vmware.com>
---
 test/integration/formposthtml_test.go | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/test/integration/formposthtml_test.go b/test/integration/formposthtml_test.go
index 21522ed3..743df1a9 100644
--- a/test/integration/formposthtml_test.go
+++ b/test/integration/formposthtml_test.go
@@ -185,7 +185,14 @@ func formpostExpectFavicon(t *testing.T, page *agouti.Page, expected string) {
 	iconURL, err := page.First("#favicon").Attribute("href")
 	require.NoError(t, err)
 	require.True(t, strings.HasPrefix(iconURL, "data:image/svg+xml,<svg"))
-	require.Contains(t, iconURL, expected)
+
+	// For some reason chromedriver on Linux returns this attribute urlencoded, but on macOS it contains the
+	// original emoji bytes (unescaped). To check correctly in both cases we allow either version here.
+	expectedEscaped := url.QueryEscape(expected)
+	require.Truef(t,
+		strings.Contains(iconURL, expected) || strings.Contains(iconURL, expectedEscaped),
+		"expected %q to contain %q or %q", iconURL, expected, expectedEscaped,
+	)
 }
 
 // formpostInitiate navigates to the template server endpoint and expects the