djpbessems/ContainerImage.Pinniped
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Allow running CLI-related integration tests with pre-built binary.

Browse Source 
This allows setting `$PINNIPED_TEST_CLI` to point at an existing `pinniped` CLI binary instead of having the test build one on-the-fly. This is more efficient when you're running the tests across many clusters as we do in CI.

Building the CLI from scratch in our CI environment takes 1.5-2 minutes, so this change should save nearly that much time on every test job.

Signed-off-by: Matt Moyer <moyerm@vmware.com>
This commit is contained in:
Matt Moyer 2021-03-23 17:17:14 -05:00
parent e70788204b
commit cda8bd6e26
No known key found for this signature in database
GPG Key ID: EAE88AD172C5AE2D
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/library/cli.go
View File

@ -1,10 +1,11 @@
// Copyright 2020 the Pinniped contributors. All Rights Reserved. // Copyright 2020-2021 the Pinniped contributors. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0 // SPDX-License-Identifier: Apache-2.0
package library package library
import ( import (
"io/ioutil" "io/ioutil"
"os"
"os/exec" "os/exec"
"path/filepath" "path/filepath"
"sync" "sync"
@ -24,6 +25,13 @@ var pinnipedCLIBinaryCache struct {
// PinnipedCLIPath returns the path to the Pinniped CLI binary, built on demand and cached between tests. // PinnipedCLIPath returns the path to the Pinniped CLI binary, built on demand and cached between tests.
func PinnipedCLIPath(t *testing.T) string { func PinnipedCLIPath(t *testing.T) string {
t.Helper() t.Helper()
// Allow a pre-built binary passed in via $PINNIPED_TEST_CLI. This is how our tests run in CI for efficiency.
if ext, ok := os.LookupEnv("PINNIPED_TEST_CLI"); ok {
t.Log("using externally provided pinniped CLI binary")
return ext
}
pinnipedCLIBinaryCache.mutex.Lock() pinnipedCLIBinaryCache.mutex.Lock()
defer pinnipedCLIBinaryCache.mutex.Unlock() defer pinnipedCLIBinaryCache.mutex.Unlock()
path := filepath.Join(testutil.TempDir(t), "pinniped") path := filepath.Join(testutil.TempDir(t), "pinniped")