From c142c52258ccff45fc7d9394b7f5400ba34d583e Mon Sep 17 00:00:00 2001 From: Joshua Casey Date: Wed, 19 Jul 2023 15:49:22 -0500 Subject: [PATCH] Do not name return variables --- .../controller/impersonatorconfig/impersonator_config.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/internal/controller/impersonatorconfig/impersonator_config.go b/internal/controller/impersonatorconfig/impersonator_config.go index a05dff37..2d6decf7 100644 --- a/internal/controller/impersonatorconfig/impersonator_config.go +++ b/internal/controller/impersonatorconfig/impersonator_config.go @@ -312,8 +312,11 @@ func (c *impersonatorConfigController) doSync(syncCtx controllerlib.Context, cre return credentialIssuerStrategyResult, nil } -func (c *impersonatorConfigController) ensureCAAndTLSSecrets(ctx context.Context, nameInfo *certNameInfo) (impersonationCABundle []byte, err error) { - var impersonationCA *certauthority.CA +func (c *impersonatorConfigController) ensureCAAndTLSSecrets(ctx context.Context, nameInfo *certNameInfo) ([]byte, error) { + var ( + impersonationCA *certauthority.CA + err error + ) if impersonationCA, err = c.ensureCASecretIsCreated(ctx); err != nil { return nil, err }