From 5aa08756e0796e57a3f031c3034785372e94128a Mon Sep 17 00:00:00 2001 From: Matt Moyer Date: Wed, 2 Jun 2021 14:48:18 -0500 Subject: [PATCH] Fix typo in CredentialIssuer ytt template. This typo wasn't caught in testing because 1) the Kubernetes API ignores the unknown field and 2) the `type` field defaults to `LoadBalancer` anyway, so things behave as expected. Even though this doesn't cause any large problems, it's quite confusing. Signed-off-by: Matt Moyer --- deploy/concierge/deployment.yaml | 2 +- deploy/concierge/values.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/deploy/concierge/deployment.yaml b/deploy/concierge/deployment.yaml index 31c7fe68..14071cff 100644 --- a/deploy/concierge/deployment.yaml +++ b/deploy/concierge/deployment.yaml @@ -260,7 +260,7 @@ spec: externalEndpoint: #@ data.values.impersonation_proxy_spec.external_endpoint #@ end service: - mode: #@ data.values.impersonation_proxy_spec.service.mode + type: #@ data.values.impersonation_proxy_spec.service.type #@ if data.values.impersonation_proxy_spec.service.load_balancer_ip: loadBalancerIP: #@ data.values.impersonation_proxy_spec.service.load_balancer_ip #@ end diff --git a/deploy/concierge/values.yaml b/deploy/concierge/values.yaml index 0445afb2..f72ea4f9 100644 --- a/deploy/concierge/values.yaml +++ b/deploy/concierge/values.yaml @@ -87,7 +87,7 @@ impersonation_proxy_spec: #! impersonation proxy. #! None does not provision either and assumes that you have set the external_endpoint #! and set up your own ingress to connect to the impersonation proxy. - mode: LoadBalancer + type: LoadBalancer #! The annotations that should be set on the ClusterIP or LoadBalancer Service. annotations: {service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout: "4000"}