djpbessems
/
ContainerImage.Pinniped
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable the goerr113 linter. 

This linter is nice in principle, but I've found it more annoying than helpful in practice.

Signed-off-by: Matt Moyer <moyerm@vmware.com>
This commit is contained in:
Matt Moyer 2020-12-07 15:51:41 -06:00
parent 040ad3293a
commit 9e945d7547
No known key found for this signature in database
GPG Key ID: EAE88AD172C5AE2D
4 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.golangci.yaml
View File

@ -30,7 +30,6 @@ linters:
- gocritic - gocritic
- gocyclo - gocyclo
- godot - godot
- goerr113
- goheader - goheader
- goimports - goimports
- golint - golint
@ -56,7 +55,6 @@ issues:
linters: linters:
- funlen - funlen
- gochecknoglobals - gochecknoglobals
- goerr113
linters-settings: linters-settings:
funlen: funlen:

2
internal/controllerlib/option.go
View File

@ -91,13 +91,11 @@ func WithInformer(getter InformerGetter, filter Filter, opt InformerOption) Opti
if err != nil { if err != nil {
tombstone, ok := obj.(cache.DeletedFinalStateUnknown) tombstone, ok := obj.(cache.DeletedFinalStateUnknown)
if !ok { if !ok {
//nolint: goerr113
utilruntime.HandleError(fmt.Errorf("%s: could not get object from tombstone: %+v", c.Name(), obj)) utilruntime.HandleError(fmt.Errorf("%s: could not get object from tombstone: %+v", c.Name(), obj))
return return
} }
accessor, err = meta.Accessor(tombstone.Obj) accessor, err = meta.Accessor(tombstone.Obj)
if err != nil { if err != nil {
//nolint: goerr113
utilruntime.HandleError(fmt.Errorf("%s: tombstone contained object that is not an accessor: %+v", c.Name(), obj)) utilruntime.HandleError(fmt.Errorf("%s: tombstone contained object that is not an accessor: %+v", c.Name(), obj))
return return
} }

1
internal/controllerlib/test/integration/examplecontroller/controller/creating.go
View File

@ -93,7 +93,6 @@ func NewExampleCreatingController(
} }
if actualSecret.Annotations[api.ServiceUIDAnnotation] != string(service.UID) { if actualSecret.Annotations[api.ServiceUIDAnnotation] != string(service.UID) {
//nolint: goerr113
utilruntime.HandleError(fmt.Errorf("secret %s/%s does not have corresponding service UID %v", actualSecret.Namespace, actualSecret.Name, service.UID)) utilruntime.HandleError(fmt.Errorf("secret %s/%s does not have corresponding service UID %v", actualSecret.Namespace, actualSecret.Name, service.UID))
return nil // drop from queue because we cannot safely update this secret return nil // drop from queue because we cannot safely update this secret
} }

1
internal/controllerlib/test/integration/examplecontroller/controller/updating.go
View File

@ -105,7 +105,6 @@ func NewExampleUpdatingController(
} }
if !isSecretValidForService(service, secret) { if !isSecretValidForService(service, secret) {
//nolint: goerr113
utilruntime.HandleError(fmt.Errorf("secret %s/%s does not have corresponding service UID %v", secret.Namespace, secret.Name, service.UID)) utilruntime.HandleError(fmt.Errorf("secret %s/%s does not have corresponding service UID %v", secret.Namespace, secret.Name, service.UID))
return nil return nil
} }