From 8ae04605ca5a79e08de90d629c6996fdf5563cf6 Mon Sep 17 00:00:00 2001 From: Ryan Richard Date: Thu, 22 Oct 2020 17:53:40 -0400 Subject: [PATCH] Add comments for magic 31234 port Also delete hack/lib/kind-config/multi-node.yaml since we don't think we will use it... Signed-off-by: Andrew Keesler --- hack/lib/kind-config/multi-node.yaml | 15 --------------- hack/lib/kind-config/single-node.yaml | 6 ++++++ hack/lib/tilt/Tiltfile | 3 +++ 3 files changed, 9 insertions(+), 15 deletions(-) delete mode 100644 hack/lib/kind-config/multi-node.yaml diff --git a/hack/lib/kind-config/multi-node.yaml b/hack/lib/kind-config/multi-node.yaml deleted file mode 100644 index 2bfa337b..00000000 --- a/hack/lib/kind-config/multi-node.yaml +++ /dev/null @@ -1,15 +0,0 @@ -kind: Cluster -apiVersion: kind.x-k8s.io/v1alpha4 -nodes: - - role: control-plane - - role: worker - - role: worker - extraPortMappings: - - protocol: TCP - containerPort: 31234 - hostPort: 12345 - listenAddress: 127.0.0.1 - - protocol: TCP - containerPort: 31235 - hostPort: 12346 - listenAddress: 127.0.0.1 diff --git a/hack/lib/kind-config/single-node.yaml b/hack/lib/kind-config/single-node.yaml index 5fb71715..83c36a58 100644 --- a/hack/lib/kind-config/single-node.yaml +++ b/hack/lib/kind-config/single-node.yaml @@ -4,10 +4,16 @@ nodes: - role: control-plane extraPortMappings: - protocol: TCP + # This same port number is hardcoded in the integration test setup + # when creating a Service on a kind cluster. It is used to talk to + # the supervisor app. containerPort: 31234 hostPort: 12345 listenAddress: 127.0.0.1 - protocol: TCP + # This same port number is hardcoded in the integration test setup + # when creating a Service on a kind cluster. It is used to talk to + # the Dex app. containerPort: 31235 hostPort: 12346 listenAddress: 127.0.0.1 diff --git a/hack/lib/tilt/Tiltfile b/hack/lib/tilt/Tiltfile index 0ab02ce7..a7fee14e 100644 --- a/hack/lib/tilt/Tiltfile +++ b/hack/lib/tilt/Tiltfile @@ -85,6 +85,9 @@ docker_build_with_restart('image/supervisor', '.', ) # Render the supervisor installation manifest using ytt. +# +# 31234 is the same port number hardcoded in the port forwarding of our kind configuration. +# Don't think that you can just change this! k8s_yaml(local([ 'ytt', '--file', '../../../deploy/supervisor',