From 6fe7a4c9dc64581f27ec35c4d66e0fb602c99f48 Mon Sep 17 00:00:00 2001 From: Matt Moyer Date: Fri, 24 Jul 2020 11:52:38 -0500 Subject: [PATCH] Add a test for when a validation function is passed. Signed-off-by: Matt Moyer --- pkg/registry/loginrequest/rest_test.go | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/pkg/registry/loginrequest/rest_test.go b/pkg/registry/loginrequest/rest_test.go index b21a8619..823ea2d6 100644 --- a/pkg/registry/loginrequest/rest_test.go +++ b/pkg/registry/loginrequest/rest_test.go @@ -8,6 +8,7 @@ package loginrequest import ( "context" "errors" + "fmt" "testing" "time" @@ -235,6 +236,21 @@ func TestCreateFailsWhenTokenValueIsEmptyInRequest(t *testing.T) { `.placeholder.suzerain-io.github.io "request name" is invalid: spec.token.value: Required value: token must be supplied`) } +func TestCreateFailsWhenValidationFails(t *testing.T) { + storage := NewREST(&FakeToken{}) + response, err := storage.Create( + context.Background(), + validLoginRequest(), + func(ctx context.Context, obj runtime.Object) error { + return fmt.Errorf("some validation error") + }, + &metav1.CreateOptions{ + DryRun: []string{}, + }) + require.Nil(t, response) + require.EqualError(t, err, "some validation error") +} + func TestCreateFailsWhenRequestOptionsDryRunIsNotEmpty(t *testing.T) { response, err := NewREST(&FakeToken{}).Create( genericapirequest.NewContext(),