djpbessems/ContainerImage.Pinniped
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

auth_handler.go: comment out currently unused fosite wiring

Browse Source 
See e8f4336 for why this is here in the first place.

Signed-off-by: Andrew Keesler <akeesler@vmware.com>
This commit is contained in:
Andrew Keesler 2020-11-04 11:20:03 -05:00
parent d8c8f04860
commit 6fe455c687
No known key found for this signature in database
GPG Key ID: 27CE0444346F9413
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
internal/oidc/auth/auth_handler.go
View File

@ -32,16 +32,26 @@ func NewHandler(
generateNonce func() (nonce.Nonce, error),
) http.Handler {
oauthHelper := compose.Compose(
// Empty Config for right now since we aren't using anything in it. We may want to inject this
// in the future since it has some really nice configuration knobs like token lifetime.
&compose.Config{},
// This is the thing that matters right now - the store is used to get information about the
// client in the authorization request.
oauthStore,
&compose.CommonStrategy{
// Shouldn't need any of this - we aren't doing auth code stuff, issuing ID tokens, or signing
// anything yet.
},
nil, // hasher, shouldn't need this - we aren't doing any client auth...yet?
compose.OAuth2AuthorizeExplicitFactory,
compose.OpenIDConnectExplicitFactory,
compose.OAuth2PKCEFactory,
// Shouldn't need any of this filled in as of right now - we aren't doing auth code stuff,
// issuing ID tokens, or signing anything yet.
&compose.CommonStrategy{},
// hasher, shouldn't need this right now - we aren't doing any client auth...yet?
nil,
// We will _probably_ want the below handlers somewhere in the code, but I'm not sure where yet,
// and we don't need them for the tests to pass currently, so they are commented out.
// compose.OAuth2AuthorizeExplicitFactory,
// compose.OpenIDConnectExplicitFactory,
// compose.OAuth2PKCEFactory,
)
return httperr.HandlerFunc(func(w http.ResponseWriter, r *http.Request) error {
if r.Method != http.MethodPost && r.Method != http.MethodGet {