From 094845752178d3d70e0831f3ded423c4427d2565 Mon Sep 17 00:00:00 2001 From: Matt Moyer Date: Fri, 23 Oct 2020 14:26:51 -0500 Subject: [PATCH 1/2] Promote the `pinniped login` command out of alpha. This was hidden behind a `pinniped alpha` hidden subcommand, but we're comfortable enough with the CLI flag interface now to promote it. Signed-off-by: Matt Moyer --- cmd/pinniped/cmd/login.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/pinniped/cmd/login.go b/cmd/pinniped/cmd/login.go index 2c0ad082..faa8b137 100644 --- a/cmd/pinniped/cmd/login.go +++ b/cmd/pinniped/cmd/login.go @@ -17,5 +17,5 @@ var loginCmd = &cobra.Command{ //nolint: gochecknoinits func init() { - alphaCmd.AddCommand(loginCmd) + rootCmd.AddCommand(loginCmd) } From 7615667b9b3e5020f838cb05a0d80b7956d5acaa Mon Sep 17 00:00:00 2001 From: Matt Moyer Date: Fri, 23 Oct 2020 14:31:15 -0500 Subject: [PATCH 2/2] Update TestCLILoginOIDC to use new non-alpha login command. Signed-off-by: Matt Moyer --- test/integration/cli_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/integration/cli_test.go b/test/integration/cli_test.go index 4df6ef66..35d2fd96 100644 --- a/test/integration/cli_test.go +++ b/test/integration/cli_test.go @@ -395,7 +395,7 @@ func spawnTestGoroutine(t *testing.T, f func() error) { func oidcLoginCommand(ctx context.Context, t *testing.T, pinnipedExe string, sessionCachePath string) *exec.Cmd { env := library.IntegrationEnv(t) - return exec.CommandContext(ctx, pinnipedExe, "alpha", "login", "oidc", + return exec.CommandContext(ctx, pinnipedExe, "login", "oidc", "--issuer", env.OIDCUpstream.Issuer, "--client-id", env.OIDCUpstream.ClientID, "--listen-port", strconv.Itoa(env.OIDCUpstream.LocalhostPort),