djpbessems/ContainerImage.Pinniped
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix typo in CredentialIssuer ytt template.

Browse Source 
This typo wasn't caught in testing because 1) the Kubernetes API ignores the unknown field and 2) the `type` field defaults to `LoadBalancer` anyway, so things behave as expected.

Even though this doesn't cause any large problems, it's quite confusing.

Signed-off-by: Matt Moyer <moyerm@vmware.com>
This commit is contained in:
Matt Moyer 2021-06-02 14:48:18 -05:00
parent 87660611d2
commit 5aa08756e0
No known key found for this signature in database
GPG Key ID: EAE88AD172C5AE2D
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
deploy/concierge/deployment.yaml
View File

@ -260,7 +260,7 @@ spec:
externalEndpoint: #@ data.values.impersonation_proxy_spec.external_endpoint externalEndpoint: #@ data.values.impersonation_proxy_spec.external_endpoint
#@ end #@ end
service: service:
mode: #@ data.values.impersonation_proxy_spec.service.mode type: #@ data.values.impersonation_proxy_spec.service.type
#@ if data.values.impersonation_proxy_spec.service.load_balancer_ip: #@ if data.values.impersonation_proxy_spec.service.load_balancer_ip:
loadBalancerIP: #@ data.values.impersonation_proxy_spec.service.load_balancer_ip loadBalancerIP: #@ data.values.impersonation_proxy_spec.service.load_balancer_ip
#@ end #@ end

2
deploy/concierge/values.yaml
View File

@ -87,7 +87,7 @@ impersonation_proxy_spec:
#! impersonation proxy. #! impersonation proxy.
#! None does not provision either and assumes that you have set the external_endpoint #! None does not provision either and assumes that you have set the external_endpoint
#! and set up your own ingress to connect to the impersonation proxy. #! and set up your own ingress to connect to the impersonation proxy.
mode: LoadBalancer type: LoadBalancer
#! The annotations that should be set on the ClusterIP or LoadBalancer Service. #! The annotations that should be set on the ClusterIP or LoadBalancer Service.
annotations: annotations:
{service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout: "4000"} {service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout: "4000"}