From 4c162be8bf3d22f8ea24e643d0054d17b5bd1136 Mon Sep 17 00:00:00 2001 From: Monis Khan Date: Mon, 15 Mar 2021 09:43:06 -0400 Subject: [PATCH] impersonator: add comment about long running func Signed-off-by: Monis Khan --- internal/concierge/impersonator/impersonator.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/internal/concierge/impersonator/impersonator.go b/internal/concierge/impersonator/impersonator.go index aae77bee..117909a4 100644 --- a/internal/concierge/impersonator/impersonator.go +++ b/internal/concierge/impersonator/impersonator.go @@ -129,6 +129,10 @@ func newInternal( //nolint:funlen // yeah, it's kind of long. serverConfig.LoopbackClientConfig.BearerToken = "" // match KAS exactly since our long running operations are just a proxy to it + // this must be kept in sync with github.com/kubernetes/kubernetes/cmd/kube-apiserver/app/server.go + // this is nothing to stress about - it has not changed since the beginning of Kube: + // v1.6 no-op move away from regex to request info https://github.com/kubernetes/kubernetes/pull/38119 + // v1.1 added pods/attach to the list https://github.com/kubernetes/kubernetes/pull/13705 serverConfig.LongRunningFunc = filters.BasicLongRunningRequestCheck( sets.NewString("watch", "proxy"), sets.NewString("attach", "exec", "proxy", "log", "portforward"),