From 792bb98680a44358198875aaf6bc1b5c563e239c Mon Sep 17 00:00:00 2001 From: Andrew Keesler Date: Wed, 13 Jan 2021 10:39:45 -0500 Subject: [PATCH] Revert "Temporarily disable max inflight checks for mutating requests" This reverts commit 4a28d1f80083fb7a46180c102e65c1e5a6f977d6. This commit was originally made to fix a bug that caused TokenCredentialRequest to become slow when the server was idle for an extended period of time. This was to address a Kubernetes issue that was fixed in 1.19.5 and onward. We are now running with Kubernetes 1.20, so we should be able to pick up this fix. --- internal/concierge/server/server.go | 7 ------- 1 file changed, 7 deletions(-) diff --git a/internal/concierge/server/server.go b/internal/concierge/server/server.go index a2beccd6..68dff190 100644 --- a/internal/concierge/server/server.go +++ b/internal/concierge/server/server.go @@ -191,13 +191,6 @@ func getAggregatedAPIServerConfig( return nil, err } - // temporarily disable max inflight checks for mutating requests until we - // pick up a fix for https://github.com/kubernetes/kubernetes/issues/95300 - // we do not need to set MaxRequestsInFlight to 0 because we are constantly - // hammered by the kubelet for /healthz and the api server for discovery - // which keeps the non-mutating request watermark histograms up to date - serverConfig.Config.MaxMutatingRequestsInFlight = 0 - apiServerConfig := &apiserver.Config{ GenericConfig: serverConfig, ExtraConfig: apiserver.ExtraConfig{