From 2f7dbed321d0f31985dc03d9f2ba2b1073de5ea7 Mon Sep 17 00:00:00 2001 From: Ryan Richard Date: Thu, 8 Jul 2021 11:17:22 -0700 Subject: [PATCH] Try increasing the "eventually" timeouts in one integration test There were 10 second timeouts in `TestAPIServingCertificateAutoCreationAndRotation` which fail often on CI. Maybe increasing the timeouts will help? --- test/integration/concierge_api_serving_certs_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/integration/concierge_api_serving_certs_test.go b/test/integration/concierge_api_serving_certs_test.go index 3689ed7a..2bb02f26 100644 --- a/test/integration/concierge_api_serving_certs_test.go +++ b/test/integration/concierge_api_serving_certs_test.go @@ -111,7 +111,7 @@ func TestAPIServingCertificateAutoCreationAndRotation(t *testing.T) { var err error secret, err = kubeClient.CoreV1().Secrets(env.ConciergeNamespace).Get(ctx, defaultServingCertResourceName, metav1.GetOptions{}) requireEventually.NoError(err) - }, 10*time.Second, 250*time.Millisecond) + }, time.Minute, 250*time.Millisecond) regeneratedCACert := secret.Data["caCertificate"] regeneratedPrivateKey := secret.Data["tlsPrivateKey"] regeneratedCertChain := secret.Data["tlsCertificateChain"] @@ -131,7 +131,7 @@ func TestAPIServingCertificateAutoCreationAndRotation(t *testing.T) { apiService, err := aggregatedClient.ApiregistrationV1().APIServices().Get(ctx, apiServiceName, metav1.GetOptions{}) requireEventually.NoErrorf(err, "get for APIService %q returned error", apiServiceName) requireEventually.Equalf(regeneratedCACert, apiService.Spec.CABundle, "CA bundle in APIService %q does not yet have the expected value", apiServiceName) - }, 10*time.Second, 250*time.Millisecond, "never saw CA certificate rotate to expected value") + }, time.Minute, 250*time.Millisecond, "never saw CA certificate rotate to expected value") // Check that we can still make requests to the aggregated API through the kube API server, // because the kube API server uses these certs when proxying requests to the aggregated API server, @@ -150,7 +150,7 @@ func TestAPIServingCertificateAutoCreationAndRotation(t *testing.T) { }, metav1.CreateOptions{}) requireEventually.NoError(err, "dynamiccertificates.Notifier broken?") } - }, 30*time.Second, 250*time.Millisecond) + }, time.Minute, 250*time.Millisecond) }) } }