djpbessems/ContainerImage.Pinniped
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test/integration: hopefully fix TestImpersonationProxy

Browse Source 
I think we were assuming the name of our Concierge app, and getting lucky
because it was the name we use when testing locally (but not in CI).

Signed-off-by: Andrew Keesler <akeesler@vmware.com>
This commit is contained in:
Andrew Keesler 2021-02-15 18:04:12 -05:00
parent 6512ab1351
commit 25bc8dd8a9
No known key found for this signature in database
GPG Key ID: 27CE0444346F9413
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/integration/concierge_impersonation_proxy_test.go
View File

@ -64,6 +64,7 @@ func TestImpersonationProxy(t *testing.T) {
// TODO if there is already a ConfigMap, remember its contents and delete it, which puts the proxy into its default settings // TODO if there is already a ConfigMap, remember its contents and delete it, which puts the proxy into its default settings
// TODO and in a t.Cleanup() if there was already a ConfigMap at the start of the test, then restore the original contents // TODO and in a t.Cleanup() if there was already a ConfigMap at the start of the test, then restore the original contents
serviceUnavailableError := fmt.Sprintf(`Get "%s/api/v1/namespaces": Service Unavailable`, proxyServiceURL)
if env.HasCapability(library.HasExternalLoadBalancerProvider) { if env.HasCapability(library.HasExternalLoadBalancerProvider) {
// Check that load balancer has been created // Check that load balancer has been created
require.Eventually(t, func() bool { require.Eventually(t, func() bool {
@ -77,7 +78,7 @@ func TestImpersonationProxy(t *testing.T) {
// Check that we can't use the impersonation proxy to execute kubectl commands yet // Check that we can't use the impersonation proxy to execute kubectl commands yet
_, err = impersonationProxyClient.CoreV1().Namespaces().List(ctx, metav1.ListOptions{}) _, err = impersonationProxyClient.CoreV1().Namespaces().List(ctx, metav1.ListOptions{})
require.EqualError(t, err, "Get \"https://pinniped-concierge-proxy.concierge.svc.cluster.local/api/v1/namespaces\": Service Unavailable") require.EqualError(t, err, serviceUnavailableError)
// Create configuration to make the impersonation proxy turn on with a hard coded endpoint (without a LoadBalancer) // Create configuration to make the impersonation proxy turn on with a hard coded endpoint (without a LoadBalancer)
configMap := configMapForConfig(t, impersonator.Config{ configMap := configMapForConfig(t, impersonator.Config{
@ -112,7 +113,7 @@ func TestImpersonationProxy(t *testing.T) {
// Check that we can't use the impersonation proxy to execute kubectl commands again // Check that we can't use the impersonation proxy to execute kubectl commands again
_, err = impersonationProxyClient.CoreV1().Namespaces().List(ctx, metav1.ListOptions{}) _, err = impersonationProxyClient.CoreV1().Namespaces().List(ctx, metav1.ListOptions{})
require.EqualError(t, err, "Get \"https://pinniped-concierge-proxy.concierge.svc.cluster.local/api/v1/namespaces\": Service Unavailable") require.EqualError(t, err, serviceUnavailableError)
// if env.HasCapability(library.HasExternalLoadBalancerProvider) { // if env.HasCapability(library.HasExternalLoadBalancerProvider) {
// TODO we started the test with a load balancer, so after forcing the proxy to disable, assert that the LoadBalancer was deleted // TODO we started the test with a load balancer, so after forcing the proxy to disable, assert that the LoadBalancer was deleted