djpbessems/ContainerImage.Pinniped
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prefer early return

Browse Source
This commit is contained in:
Joshua Casey 2023-06-07 20:50:09 -05:00
parent 8d8e1f3abd
commit 10c3e482b4
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
internal/issuer/issuer.go
View File

@ -1,4 +1,4 @@
// Copyright 2021 the Pinniped contributors. All Rights Reserved. // Copyright 2021-2023 the Pinniped contributors. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0 // SPDX-License-Identifier: Apache-2.0
package issuer package issuer
@ -42,12 +42,11 @@ func (c ClientCertIssuers) IssueClientCertPEM(username string, groups []string,
for _, issuer := range c { for _, issuer := range c {
certPEM, keyPEM, err := issuer.IssueClientCertPEM(username, groups, ttl) certPEM, keyPEM, err := issuer.IssueClientCertPEM(username, groups, ttl)
if err != nil { if err == nil {
errs = append(errs, fmt.Errorf("%s failed to issue client cert: %w", issuer.Name(), err))
continue
}
return certPEM, keyPEM, nil return certPEM, keyPEM, nil
} }
errs = append(errs, fmt.Errorf("%s failed to issue client cert: %w", issuer.Name(), err))
}
if err := errors.NewAggregate(errs); err != nil { if err := errors.NewAggregate(errs); err != nil {
return nil, nil, err return nil, nil, err