djpbessems/ContainerImage.Pinniped
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Changes to make the linter pass

Browse Source
This commit is contained in:
Margo Crawford 2021-05-19 11:05:35 -07:00
parent 297a484948
commit 0b66321902
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
internal/controller/impersonatorconfig/impersonator_config.go
View File

@ -462,7 +462,7 @@ func (c *impersonatorConfigController) ensureLoadBalancerIsStarted(ctx context.C
"service", c.generatedLoadBalancerServiceName,
"namespace", c.namespace)
_, err = c.k8sClient.CoreV1().Services(c.namespace).Update(ctx, &loadBalancer, metav1.UpdateOptions{})
// TODO: make sure this error is handled if necessary
return err
}
return nil
}
@ -689,10 +689,10 @@ func (c *impersonatorConfigController) findDesiredTLSCertificateName(config *v1a
// - clusterip and no external endpoint
if config.ExternalEndpoint != "" {
return c.findTLSCertificateNameFromEndpointConfig(config), nil
} else if config.Service.Type == v1alpha1.ImpersonationProxyServiceTypeClusterIP {
// c.findTLSCertificateNameFromClusterIPService()
// TODO implement this
}
} // else if config.Service.Type == v1alpha1.ImpersonationProxyServiceTypeClusterIP {
// // c.findTLSCertificateNameFromClusterIPService()
// // TODO implement this
//}
return c.findTLSCertificateNameFromLoadBalancer()
}