2020-09-16 14:19:51 +00:00
|
|
|
// Copyright 2020 the Pinniped contributors. All Rights Reserved.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0
|
2020-08-19 20:15:45 +00:00
|
|
|
|
|
|
|
package apicerts
|
|
|
|
|
|
|
|
import (
|
|
|
|
"crypto/x509"
|
|
|
|
"encoding/pem"
|
|
|
|
"fmt"
|
|
|
|
"time"
|
|
|
|
|
|
|
|
corev1 "k8s.io/api/core/v1"
|
|
|
|
k8serrors "k8s.io/apimachinery/pkg/api/errors"
|
|
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
|
|
corev1informers "k8s.io/client-go/informers/core/v1"
|
|
|
|
"k8s.io/client-go/kubernetes"
|
|
|
|
"k8s.io/klog/v2"
|
|
|
|
|
2020-09-18 19:56:24 +00:00
|
|
|
"go.pinniped.dev/internal/constable"
|
|
|
|
pinnipedcontroller "go.pinniped.dev/internal/controller"
|
|
|
|
"go.pinniped.dev/internal/controllerlib"
|
2020-08-19 20:15:45 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
type certsExpirerController struct {
|
Rename many of resources that are created in Kubernetes by Pinniped
New resource naming conventions:
- Do not repeat the Kind in the name,
e.g. do not call it foo-cluster-role-binding, just call it foo
- Names will generally start with a prefix to identify our component,
so when a user lists all objects of that kind, they can tell to which
component it is related,
e.g. `kubectl get configmaps` would list one named "pinniped-config"
- It should be possible for an operator to make the word "pinniped"
mostly disappear if they choose, by specifying the app_name in
values.yaml, to the extent that is practical (but not from APIService
names because those are hardcoded in golang)
- Each role/clusterrole and its corresponding binding have the same name
- Pinniped resource names that must be known by the server golang code
are passed to the code at run time via ConfigMap, rather than
hardcoded in the golang code. This also allows them to be prepended
with the app_name from values.yaml while creating the ConfigMap.
- Since the CLI `get-kubeconfig` command cannot guess the name of the
CredentialIssuerConfig resource in advance anymore, it lists all
CredentialIssuerConfig in the app's namespace and returns an error
if there is not exactly one found, and then uses that one regardless
of its name
2020-09-18 22:56:50 +00:00
|
|
|
namespace string
|
|
|
|
certsSecretResourceName string
|
|
|
|
k8sClient kubernetes.Interface
|
|
|
|
secretInformer corev1informers.SecretInformer
|
2020-08-19 20:15:45 +00:00
|
|
|
|
2020-08-20 19:17:18 +00:00
|
|
|
// renewBefore is the amount of time after the cert's issuance where
|
|
|
|
// this controller will start to try to rotate it.
|
|
|
|
renewBefore time.Duration
|
2020-08-19 20:15:45 +00:00
|
|
|
}
|
|
|
|
|
2020-08-28 15:59:09 +00:00
|
|
|
// NewCertsExpirerController returns a controllerlib.Controller that will delete a
|
2020-08-20 19:17:18 +00:00
|
|
|
// certificate secret once it gets within some threshold of its expiration time. The
|
|
|
|
// deletion forces rotation of the secret with the help of other controllers.
|
2020-08-19 20:15:45 +00:00
|
|
|
func NewCertsExpirerController(
|
|
|
|
namespace string,
|
Rename many of resources that are created in Kubernetes by Pinniped
New resource naming conventions:
- Do not repeat the Kind in the name,
e.g. do not call it foo-cluster-role-binding, just call it foo
- Names will generally start with a prefix to identify our component,
so when a user lists all objects of that kind, they can tell to which
component it is related,
e.g. `kubectl get configmaps` would list one named "pinniped-config"
- It should be possible for an operator to make the word "pinniped"
mostly disappear if they choose, by specifying the app_name in
values.yaml, to the extent that is practical (but not from APIService
names because those are hardcoded in golang)
- Each role/clusterrole and its corresponding binding have the same name
- Pinniped resource names that must be known by the server golang code
are passed to the code at run time via ConfigMap, rather than
hardcoded in the golang code. This also allows them to be prepended
with the app_name from values.yaml while creating the ConfigMap.
- Since the CLI `get-kubeconfig` command cannot guess the name of the
CredentialIssuerConfig resource in advance anymore, it lists all
CredentialIssuerConfig in the app's namespace and returns an error
if there is not exactly one found, and then uses that one regardless
of its name
2020-09-18 22:56:50 +00:00
|
|
|
certsSecretResourceName string,
|
2020-08-19 20:15:45 +00:00
|
|
|
k8sClient kubernetes.Interface,
|
|
|
|
secretInformer corev1informers.SecretInformer,
|
2020-08-20 17:54:15 +00:00
|
|
|
withInformer pinnipedcontroller.WithInformerOptionFunc,
|
2020-08-20 19:17:18 +00:00
|
|
|
renewBefore time.Duration,
|
2020-08-28 15:59:09 +00:00
|
|
|
) controllerlib.Controller {
|
|
|
|
return controllerlib.New(
|
|
|
|
controllerlib.Config{
|
2020-08-19 20:15:45 +00:00
|
|
|
Name: "certs-expirer-controller",
|
|
|
|
Syncer: &certsExpirerController{
|
Rename many of resources that are created in Kubernetes by Pinniped
New resource naming conventions:
- Do not repeat the Kind in the name,
e.g. do not call it foo-cluster-role-binding, just call it foo
- Names will generally start with a prefix to identify our component,
so when a user lists all objects of that kind, they can tell to which
component it is related,
e.g. `kubectl get configmaps` would list one named "pinniped-config"
- It should be possible for an operator to make the word "pinniped"
mostly disappear if they choose, by specifying the app_name in
values.yaml, to the extent that is practical (but not from APIService
names because those are hardcoded in golang)
- Each role/clusterrole and its corresponding binding have the same name
- Pinniped resource names that must be known by the server golang code
are passed to the code at run time via ConfigMap, rather than
hardcoded in the golang code. This also allows them to be prepended
with the app_name from values.yaml while creating the ConfigMap.
- Since the CLI `get-kubeconfig` command cannot guess the name of the
CredentialIssuerConfig resource in advance anymore, it lists all
CredentialIssuerConfig in the app's namespace and returns an error
if there is not exactly one found, and then uses that one regardless
of its name
2020-09-18 22:56:50 +00:00
|
|
|
namespace: namespace,
|
|
|
|
certsSecretResourceName: certsSecretResourceName,
|
|
|
|
k8sClient: k8sClient,
|
|
|
|
secretInformer: secretInformer,
|
|
|
|
renewBefore: renewBefore,
|
2020-08-19 20:15:45 +00:00
|
|
|
},
|
|
|
|
},
|
|
|
|
withInformer(
|
|
|
|
secretInformer,
|
Rename many of resources that are created in Kubernetes by Pinniped
New resource naming conventions:
- Do not repeat the Kind in the name,
e.g. do not call it foo-cluster-role-binding, just call it foo
- Names will generally start with a prefix to identify our component,
so when a user lists all objects of that kind, they can tell to which
component it is related,
e.g. `kubectl get configmaps` would list one named "pinniped-config"
- It should be possible for an operator to make the word "pinniped"
mostly disappear if they choose, by specifying the app_name in
values.yaml, to the extent that is practical (but not from APIService
names because those are hardcoded in golang)
- Each role/clusterrole and its corresponding binding have the same name
- Pinniped resource names that must be known by the server golang code
are passed to the code at run time via ConfigMap, rather than
hardcoded in the golang code. This also allows them to be prepended
with the app_name from values.yaml while creating the ConfigMap.
- Since the CLI `get-kubeconfig` command cannot guess the name of the
CredentialIssuerConfig resource in advance anymore, it lists all
CredentialIssuerConfig in the app's namespace and returns an error
if there is not exactly one found, and then uses that one regardless
of its name
2020-09-18 22:56:50 +00:00
|
|
|
pinnipedcontroller.NameAndNamespaceExactMatchFilterFactory(certsSecretResourceName, namespace),
|
2020-08-28 15:59:09 +00:00
|
|
|
controllerlib.InformerOption{},
|
2020-08-19 20:15:45 +00:00
|
|
|
),
|
|
|
|
)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Sync implements controller.Syncer.Sync.
|
2020-08-28 15:59:09 +00:00
|
|
|
func (c *certsExpirerController) Sync(ctx controllerlib.Context) error {
|
Rename many of resources that are created in Kubernetes by Pinniped
New resource naming conventions:
- Do not repeat the Kind in the name,
e.g. do not call it foo-cluster-role-binding, just call it foo
- Names will generally start with a prefix to identify our component,
so when a user lists all objects of that kind, they can tell to which
component it is related,
e.g. `kubectl get configmaps` would list one named "pinniped-config"
- It should be possible for an operator to make the word "pinniped"
mostly disappear if they choose, by specifying the app_name in
values.yaml, to the extent that is practical (but not from APIService
names because those are hardcoded in golang)
- Each role/clusterrole and its corresponding binding have the same name
- Pinniped resource names that must be known by the server golang code
are passed to the code at run time via ConfigMap, rather than
hardcoded in the golang code. This also allows them to be prepended
with the app_name from values.yaml while creating the ConfigMap.
- Since the CLI `get-kubeconfig` command cannot guess the name of the
CredentialIssuerConfig resource in advance anymore, it lists all
CredentialIssuerConfig in the app's namespace and returns an error
if there is not exactly one found, and then uses that one regardless
of its name
2020-09-18 22:56:50 +00:00
|
|
|
secret, err := c.secretInformer.Lister().Secrets(c.namespace).Get(c.certsSecretResourceName)
|
2020-08-19 20:15:45 +00:00
|
|
|
notFound := k8serrors.IsNotFound(err)
|
|
|
|
if err != nil && !notFound {
|
Rename many of resources that are created in Kubernetes by Pinniped
New resource naming conventions:
- Do not repeat the Kind in the name,
e.g. do not call it foo-cluster-role-binding, just call it foo
- Names will generally start with a prefix to identify our component,
so when a user lists all objects of that kind, they can tell to which
component it is related,
e.g. `kubectl get configmaps` would list one named "pinniped-config"
- It should be possible for an operator to make the word "pinniped"
mostly disappear if they choose, by specifying the app_name in
values.yaml, to the extent that is practical (but not from APIService
names because those are hardcoded in golang)
- Each role/clusterrole and its corresponding binding have the same name
- Pinniped resource names that must be known by the server golang code
are passed to the code at run time via ConfigMap, rather than
hardcoded in the golang code. This also allows them to be prepended
with the app_name from values.yaml while creating the ConfigMap.
- Since the CLI `get-kubeconfig` command cannot guess the name of the
CredentialIssuerConfig resource in advance anymore, it lists all
CredentialIssuerConfig in the app's namespace and returns an error
if there is not exactly one found, and then uses that one regardless
of its name
2020-09-18 22:56:50 +00:00
|
|
|
return fmt.Errorf("failed to get %s/%s secret: %w", c.namespace, c.certsSecretResourceName, err)
|
2020-08-19 20:15:45 +00:00
|
|
|
}
|
|
|
|
if notFound {
|
2020-09-08 23:36:49 +00:00
|
|
|
klog.Info("certsExpirerController Sync found that the secret does not exist yet or was deleted")
|
2020-08-19 20:15:45 +00:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2020-08-20 19:17:18 +00:00
|
|
|
notBefore, notAfter, err := getCertBounds(secret)
|
2020-08-19 20:15:45 +00:00
|
|
|
if err != nil {
|
2020-08-20 19:17:18 +00:00
|
|
|
// If we can't read the cert, then really all we can do is log something,
|
|
|
|
// since if we returned an error then the controller lib would just call us
|
|
|
|
// again and again, which would probably yield the same results.
|
2020-09-08 23:36:49 +00:00
|
|
|
klog.Warningf("certsExpirerController Sync found that the secret is malformed: %s", err.Error())
|
2020-08-19 20:15:45 +00:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2020-08-20 19:17:18 +00:00
|
|
|
certAge := time.Since(notBefore)
|
|
|
|
renewDelta := certAge - c.renewBefore
|
2020-09-08 23:36:49 +00:00
|
|
|
klog.Infof("certsExpirerController Sync found a renew delta of %s", renewDelta)
|
2020-08-20 19:17:18 +00:00
|
|
|
if renewDelta >= 0 || time.Now().After(notAfter) {
|
2020-08-19 20:15:45 +00:00
|
|
|
err := c.k8sClient.
|
|
|
|
CoreV1().
|
|
|
|
Secrets(c.namespace).
|
Rename many of resources that are created in Kubernetes by Pinniped
New resource naming conventions:
- Do not repeat the Kind in the name,
e.g. do not call it foo-cluster-role-binding, just call it foo
- Names will generally start with a prefix to identify our component,
so when a user lists all objects of that kind, they can tell to which
component it is related,
e.g. `kubectl get configmaps` would list one named "pinniped-config"
- It should be possible for an operator to make the word "pinniped"
mostly disappear if they choose, by specifying the app_name in
values.yaml, to the extent that is practical (but not from APIService
names because those are hardcoded in golang)
- Each role/clusterrole and its corresponding binding have the same name
- Pinniped resource names that must be known by the server golang code
are passed to the code at run time via ConfigMap, rather than
hardcoded in the golang code. This also allows them to be prepended
with the app_name from values.yaml while creating the ConfigMap.
- Since the CLI `get-kubeconfig` command cannot guess the name of the
CredentialIssuerConfig resource in advance anymore, it lists all
CredentialIssuerConfig in the app's namespace and returns an error
if there is not exactly one found, and then uses that one regardless
of its name
2020-09-18 22:56:50 +00:00
|
|
|
Delete(ctx.Context, c.certsSecretResourceName, metav1.DeleteOptions{})
|
2020-08-19 20:15:45 +00:00
|
|
|
if err != nil {
|
|
|
|
// Do return an error here so that the controller library will reschedule
|
|
|
|
// us to try deleting this cert again.
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2020-08-20 19:17:18 +00:00
|
|
|
// getCertBounds returns the NotBefore and NotAfter fields of the TLS
|
|
|
|
// certificate in the provided secret, or an error. Not that it expects the
|
|
|
|
// provided secret to contain the well-known data keys from this package (see
|
|
|
|
// certs_manager.go).
|
|
|
|
func getCertBounds(secret *corev1.Secret) (time.Time, time.Time, error) {
|
|
|
|
certPEM := secret.Data[tlsCertificateChainSecretKey]
|
|
|
|
if certPEM == nil {
|
|
|
|
return time.Time{}, time.Time{}, constable.Error("failed to find certificate")
|
2020-08-19 20:15:45 +00:00
|
|
|
}
|
|
|
|
|
2020-08-20 19:17:18 +00:00
|
|
|
certBlock, _ := pem.Decode(certPEM)
|
|
|
|
if certBlock == nil {
|
|
|
|
return time.Time{}, time.Time{}, constable.Error("failed to decode certificate PEM")
|
2020-08-19 20:15:45 +00:00
|
|
|
}
|
|
|
|
|
2020-08-20 19:17:18 +00:00
|
|
|
cert, err := x509.ParseCertificate(certBlock.Bytes)
|
2020-08-19 20:15:45 +00:00
|
|
|
if err != nil {
|
2020-08-20 19:17:18 +00:00
|
|
|
return time.Time{}, time.Time{}, fmt.Errorf("failed to parse certificate: %w", err)
|
2020-08-19 20:15:45 +00:00
|
|
|
}
|
|
|
|
|
2020-08-20 19:17:18 +00:00
|
|
|
return cert.NotBefore, cert.NotAfter, nil
|
2020-08-19 20:15:45 +00:00
|
|
|
}
|